mlxsw: i2c: Limit single transaction buffer size
[ Upstream commitd7248f1cc8
] Maximum size of buffer is obtained from underlying I2C adapter and in case adapter allows I2C transaction buffer size greater than 100 bytes, transaction will fail due to firmware limitation. As a result driver will fail initialization. Limit the maximum size of transaction buffer by 100 bytes to fit to firmware. Remove unnecessary calculation: max_t(u16, MLXSW_I2C_BLK_DEF, quirk_size). This condition can not happened. Fixes:3029a693be
("mlxsw: i2c: Allow flexible setting of I2C transactions size") Signed-off-by: Vadim Pasternak <vadimp@nvidia.com> Reviewed-by: Petr Machata <petrm@nvidia.com> Signed-off-by: Petr Machata <petrm@nvidia.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Родитель
7790b6a2f5
Коммит
a85fd81165
|
@ -47,6 +47,7 @@
|
|||
#define MLXSW_I2C_MBOX_SIZE_BITS 12
|
||||
#define MLXSW_I2C_ADDR_BUF_SIZE 4
|
||||
#define MLXSW_I2C_BLK_DEF 32
|
||||
#define MLXSW_I2C_BLK_MAX 100
|
||||
#define MLXSW_I2C_RETRY 5
|
||||
#define MLXSW_I2C_TIMEOUT_MSECS 5000
|
||||
#define MLXSW_I2C_MAX_DATA_SIZE 256
|
||||
|
@ -576,7 +577,7 @@ static int mlxsw_i2c_probe(struct i2c_client *client,
|
|||
return -EOPNOTSUPP;
|
||||
}
|
||||
|
||||
mlxsw_i2c->block_size = max_t(u16, MLXSW_I2C_BLK_DEF,
|
||||
mlxsw_i2c->block_size = min_t(u16, MLXSW_I2C_BLK_MAX,
|
||||
min_t(u16, quirks->max_read_len,
|
||||
quirks->max_write_len));
|
||||
} else {
|
||||
|
|
Загрузка…
Ссылка в новой задаче