leds: leds-cobalt-qube: Use devm_led_classdev_register
Use resource-managed function devm_led_classdev_register instead of led_classdev_register to make the error-path simpler. To be compatible with the change, goto is replaced with direct return, unneeded label err_null is dropped and unnecessary variable retval is removed. Also, remove redundant cobalt_qube_led_remove. Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
This commit is contained in:
Родитель
6a13feb9c8
Коммит
aa4e252495
|
@ -36,7 +36,6 @@ static struct led_classdev qube_front_led = {
|
|||
static int cobalt_qube_led_probe(struct platform_device *pdev)
|
||||
{
|
||||
struct resource *res;
|
||||
int retval;
|
||||
|
||||
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
||||
if (!res)
|
||||
|
@ -49,31 +48,11 @@ static int cobalt_qube_led_probe(struct platform_device *pdev)
|
|||
led_value = LED_FRONT_LEFT | LED_FRONT_RIGHT;
|
||||
writeb(led_value, led_port);
|
||||
|
||||
retval = led_classdev_register(&pdev->dev, &qube_front_led);
|
||||
if (retval)
|
||||
goto err_null;
|
||||
|
||||
return 0;
|
||||
|
||||
err_null:
|
||||
led_port = NULL;
|
||||
|
||||
return retval;
|
||||
}
|
||||
|
||||
static int cobalt_qube_led_remove(struct platform_device *pdev)
|
||||
{
|
||||
led_classdev_unregister(&qube_front_led);
|
||||
|
||||
if (led_port)
|
||||
led_port = NULL;
|
||||
|
||||
return 0;
|
||||
return devm_led_classdev_register(&pdev->dev, &qube_front_led);
|
||||
}
|
||||
|
||||
static struct platform_driver cobalt_qube_led_driver = {
|
||||
.probe = cobalt_qube_led_probe,
|
||||
.remove = cobalt_qube_led_remove,
|
||||
.driver = {
|
||||
.name = "cobalt-qube-leds",
|
||||
},
|
||||
|
|
Загрузка…
Ссылка в новой задаче