staging: brcm80211: use correct pointer types in bcm_pktq_flush
to clarify the intention: On Sun, May 15, 2011 at 09:54:26PM +0200, Arend van Spriel wrote: > On 05/15/2011 08:10 PM, Hauke Mehrtens wrote: [...] >> Why don't you use the correct pointer type here instead of casting then >> around and the parameter names are meaningless too. >> >> static bool cb_del_ampdu_pkt(struct sk_buff *mpdu, struct >> cb_del_ampdu_pars *ampdu_pars) [...] > Actually this is a generic callback mechanism in which an additional > parameter can be passed, which can be of *any* type hence a void pointer > seems justified here and a meaningless name is used. I do agree that the > txi parameter will always be a struct sk_buff and should be indicated as > such. Reported-by: Hauke Mehrtens <hauke@hauke-m.de> Signed-off-by: Clemens Noss <cnoss@gmx.de> Acked-by: Roland Vossen <rvossen@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Родитель
84067de664
Коммит
aacd531df9
|
@ -1204,9 +1204,8 @@ void wlc_ampdu_shm_upd(struct ampdu_info *ampdu)
|
||||||
/*
|
/*
|
||||||
* callback function that helps flushing ampdu packets from a priority queue
|
* callback function that helps flushing ampdu packets from a priority queue
|
||||||
*/
|
*/
|
||||||
static bool cb_del_ampdu_pkt(void *p, void *arg_a)
|
static bool cb_del_ampdu_pkt(struct sk_buff *mpdu, void *arg_a)
|
||||||
{
|
{
|
||||||
struct sk_buff *mpdu = (struct sk_buff *)p;
|
|
||||||
struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(mpdu);
|
struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(mpdu);
|
||||||
struct cb_del_ampdu_pars *ampdu_pars =
|
struct cb_del_ampdu_pars *ampdu_pars =
|
||||||
(struct cb_del_ampdu_pars *)arg_a;
|
(struct cb_del_ampdu_pars *)arg_a;
|
||||||
|
|
|
@ -74,7 +74,7 @@
|
||||||
#define PKTQ_PREC_ITER(pq, prec) for (prec = (pq)->num_prec - 1; prec >= 0; prec--)
|
#define PKTQ_PREC_ITER(pq, prec) for (prec = (pq)->num_prec - 1; prec >= 0; prec--)
|
||||||
|
|
||||||
/* fn(pkt, arg). return true if pkt belongs to if */
|
/* fn(pkt, arg). return true if pkt belongs to if */
|
||||||
typedef bool(*ifpkt_cb_t) (void *, void *);
|
typedef bool(*ifpkt_cb_t) (struct sk_buff *, void *);
|
||||||
|
|
||||||
/* operations on a specific precedence in packet queue */
|
/* operations on a specific precedence in packet queue */
|
||||||
|
|
||||||
|
|
Загрузка…
Ссылка в новой задаче