ieee802154: hwsim: Fix possible memory leak in hwsim_subscribe_all_others
In hwsim_subscribe_all_others, the error handling code performs
incorrectly if the second hwsim_alloc_edge fails. When this issue occurs,
it goes to sub_fail, without cleaning the edges allocated before.
Fixes: f25da51fdc
("ieee802154: hwsim: add replacement for fakelb")
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Acked-by: Alexander Aring <aahringo@redhat.com>
Link: https://lore.kernel.org/r/20210611015812.1626999-1-mudongliangabcd@gmail.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
This commit is contained in:
Родитель
f2386cf7c5
Коммит
ab372c2293
|
@ -715,6 +715,8 @@ static int hwsim_subscribe_all_others(struct hwsim_phy *phy)
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
|
|
||||||
|
sub_fail:
|
||||||
|
hwsim_edge_unsubscribe_me(phy);
|
||||||
me_fail:
|
me_fail:
|
||||||
rcu_read_lock();
|
rcu_read_lock();
|
||||||
list_for_each_entry_rcu(e, &phy->edges, list) {
|
list_for_each_entry_rcu(e, &phy->edges, list) {
|
||||||
|
@ -722,8 +724,6 @@ me_fail:
|
||||||
hwsim_free_edge(e);
|
hwsim_free_edge(e);
|
||||||
}
|
}
|
||||||
rcu_read_unlock();
|
rcu_read_unlock();
|
||||||
sub_fail:
|
|
||||||
hwsim_edge_unsubscribe_me(phy);
|
|
||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Загрузка…
Ссылка в новой задаче