drm/mcde: fix masking and bitwise-or on variable val
The masking of val with ~MCDE_CRX1_CLKSEL_MASK is currently being
ignored because there seems to be a missing bitwise-or of val in the
following statement. Fix this by replacing the assignment of val
with a bitwise-or.
Fixes: d795fd3220
("drm/mcde: Support DPI output")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Unused valued")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20201124121528.395681-1-colin.king@canonical.com
This commit is contained in:
Родитель
bf8975837d
Коммит
ab43108d0d
|
@ -738,7 +738,7 @@ static void mcde_configure_fifo(struct mcde *mcde, enum mcde_fifo fifo,
|
|||
} else {
|
||||
/* Use the MCDE clock for DSI */
|
||||
val &= ~MCDE_CRX1_CLKSEL_MASK;
|
||||
val = MCDE_CRX1_CLKSEL_MCDECLK << MCDE_CRX1_CLKSEL_SHIFT;
|
||||
val |= MCDE_CRX1_CLKSEL_MCDECLK << MCDE_CRX1_CLKSEL_SHIFT;
|
||||
}
|
||||
writel(val, mcde->regs + cr1);
|
||||
spin_unlock(&mcde->fifo_crx1_lock);
|
||||
|
|
Загрузка…
Ссылка в новой задаче