PCI: xilinx: Fix harmless format string warning
The xilinx PCIe driver prints a register value whose type is propagated to
the type returned by the GENMASK() macro. Unfortunately, that type has
recently changed as the result of a bug fix, so now we get a warning about
the type:
drivers/pci/host/pcie-xilinx.c: In function 'xilinx_pcie_clear_err_interrupts':
drivers/pci/host/pcie-xilinx.c:154:3: warning: format '%d' expects argument of type 'int', but argument 4 has type 'long unsigned int' [-Wformat=]
Change the code so we always print the number as an 'unsigned long' type to
avoid the warning. The original code was fine on 32-bit architectures but
not on 64-bit. Now it works as expected on both.
Fixes: 00b4d9a141
("bitops: Fix shift overflow in GENMASK macros")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>
This commit is contained in:
Родитель
97bf6af1f9
Коммит
abc596b9a2
|
@ -148,10 +148,10 @@ static inline bool xilinx_pcie_link_is_up(struct xilinx_pcie_port *port)
|
||||||
*/
|
*/
|
||||||
static void xilinx_pcie_clear_err_interrupts(struct xilinx_pcie_port *port)
|
static void xilinx_pcie_clear_err_interrupts(struct xilinx_pcie_port *port)
|
||||||
{
|
{
|
||||||
u32 val = pcie_read(port, XILINX_PCIE_REG_RPEFR);
|
unsigned long val = pcie_read(port, XILINX_PCIE_REG_RPEFR);
|
||||||
|
|
||||||
if (val & XILINX_PCIE_RPEFR_ERR_VALID) {
|
if (val & XILINX_PCIE_RPEFR_ERR_VALID) {
|
||||||
dev_dbg(port->dev, "Requester ID %d\n",
|
dev_dbg(port->dev, "Requester ID %lu\n",
|
||||||
val & XILINX_PCIE_RPEFR_REQ_ID);
|
val & XILINX_PCIE_RPEFR_REQ_ID);
|
||||||
pcie_write(port, XILINX_PCIE_RPEFR_ALL_MASK,
|
pcie_write(port, XILINX_PCIE_RPEFR_ALL_MASK,
|
||||||
XILINX_PCIE_REG_RPEFR);
|
XILINX_PCIE_REG_RPEFR);
|
||||||
|
|
Загрузка…
Ссылка в новой задаче