thinkpad_acpi: signedness bugs getting current_mode
This needs to be signed for the error handling to work. Valid modes are
small positive integers.
Fixes: b790ceeb0f
('thinkpad_acpi: Add adaptive_kbd_mode sysfs attr')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-By: Bastien Nocera <hadess@hadess.net>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
This commit is contained in:
Родитель
b4dd04ac6e
Коммит
abf9dc0d9a
|
@ -2938,7 +2938,7 @@ static ssize_t adaptive_kbd_mode_show(struct device *dev,
|
|||
struct device_attribute *attr,
|
||||
char *buf)
|
||||
{
|
||||
u32 current_mode;
|
||||
int current_mode;
|
||||
|
||||
current_mode = adaptive_keyboard_get_mode();
|
||||
if (current_mode < 0)
|
||||
|
@ -3621,7 +3621,7 @@ static int adaptive_keyboard_get_next_mode(int mode)
|
|||
|
||||
static bool adaptive_keyboard_hotkey_notify_hotkey(unsigned int scancode)
|
||||
{
|
||||
u32 current_mode = 0;
|
||||
int current_mode = 0;
|
||||
int new_mode = 0;
|
||||
int keycode;
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче