media: rkisp1: params: fix wrong bits settings
The histogram mode is set using 'rkisp1_params_set_bits'.
Only the bits of the mode should be the value argument for
that function. Otherwise bits outside the mode mask are
turned on which is not what was intended.
Fixes: bae1155cf5
("media: staging: rkisp1: add output device for parameters")
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Родитель
147d211cc9
Коммит
ac74672917
|
@ -1233,7 +1233,6 @@ static void rkisp1_params_config_parameter(struct rkisp1_params *params)
|
||||||
memset(hst.hist_weight, 0x01, sizeof(hst.hist_weight));
|
memset(hst.hist_weight, 0x01, sizeof(hst.hist_weight));
|
||||||
rkisp1_hst_config(params, &hst);
|
rkisp1_hst_config(params, &hst);
|
||||||
rkisp1_param_set_bits(params, RKISP1_CIF_ISP_HIST_PROP,
|
rkisp1_param_set_bits(params, RKISP1_CIF_ISP_HIST_PROP,
|
||||||
~RKISP1_CIF_ISP_HIST_PROP_MODE_MASK |
|
|
||||||
rkisp1_hst_params_default_config.mode);
|
rkisp1_hst_params_default_config.mode);
|
||||||
|
|
||||||
/* set the range */
|
/* set the range */
|
||||||
|
|
Загрузка…
Ссылка в новой задаче