fbdev: Use fallthrough pseudo-keyword
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Link: https://patchwork.freedesktop.org/patch/msgid/20200707210539.GA12530@embeddedor
This commit is contained in:
Родитель
85806f6d58
Коммит
ad04fae0de
|
@ -857,7 +857,7 @@ static void acornfb_parse_dram(char *opt)
|
|||
case 'M':
|
||||
case 'm':
|
||||
size *= 1024;
|
||||
/* Fall through */
|
||||
fallthrough;
|
||||
case 'K':
|
||||
case 'k':
|
||||
size *= 1024;
|
||||
|
|
|
@ -419,7 +419,7 @@ static int arcfb_ioctl(struct fb_info *info,
|
|||
schedule();
|
||||
finish_wait(&arcfb_waitq, &wait);
|
||||
}
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
|
||||
case FBIO_GETCONTROL2:
|
||||
{
|
||||
|
|
|
@ -508,7 +508,7 @@ static int atmel_lcdfb_check_var(struct fb_var_screeninfo *var,
|
|||
case 32:
|
||||
var->transp.offset = 24;
|
||||
var->transp.length = 8;
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case 24:
|
||||
if (pdata->lcd_wiring_mode == ATMEL_LCDC_WIRING_RGB) {
|
||||
/* RGB:888 mode */
|
||||
|
@ -633,7 +633,7 @@ static int atmel_lcdfb_set_par(struct fb_info *info)
|
|||
case 2: value |= ATMEL_LCDC_PIXELSIZE_2; break;
|
||||
case 4: value |= ATMEL_LCDC_PIXELSIZE_4; break;
|
||||
case 8: value |= ATMEL_LCDC_PIXELSIZE_8; break;
|
||||
case 15: /* fall through */
|
||||
case 15: fallthrough;
|
||||
case 16: value |= ATMEL_LCDC_PIXELSIZE_16; break;
|
||||
case 24: value |= ATMEL_LCDC_PIXELSIZE_24; break;
|
||||
case 32: value |= ATMEL_LCDC_PIXELSIZE_32; break;
|
||||
|
|
|
@ -1208,11 +1208,11 @@ static void radeon_pm_enable_dll_m10(struct radeonfb_info *rinfo)
|
|||
case 1:
|
||||
if (mc & 0x4)
|
||||
break;
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case 2:
|
||||
dll_sleep_mask |= MDLL_R300_RDCK__MRDCKB_SLEEP;
|
||||
dll_reset_mask |= MDLL_R300_RDCK__MRDCKB_RESET;
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case 0:
|
||||
dll_sleep_mask |= MDLL_R300_RDCK__MRDCKA_SLEEP;
|
||||
dll_reset_mask |= MDLL_R300_RDCK__MRDCKA_RESET;
|
||||
|
@ -1221,7 +1221,7 @@ static void radeon_pm_enable_dll_m10(struct radeonfb_info *rinfo)
|
|||
case 1:
|
||||
if (!(mc & 0x4))
|
||||
break;
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case 2:
|
||||
dll_sleep_mask |= MDLL_R300_RDCK__MRDCKD_SLEEP;
|
||||
dll_reset_mask |= MDLL_R300_RDCK__MRDCKD_RESET;
|
||||
|
|
|
@ -1476,11 +1476,11 @@ static void init_vgachip(struct fb_info *info)
|
|||
mdelay(100);
|
||||
/* mode */
|
||||
vga_wgfx(cinfo->regbase, CL_GR31, 0x00);
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case BT_GD5480:
|
||||
/* from Klaus' NetBSD driver: */
|
||||
vga_wgfx(cinfo->regbase, CL_GR2F, 0x00);
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case BT_ALPINE:
|
||||
/* put blitter into 542x compat */
|
||||
vga_wgfx(cinfo->regbase, CL_GR33, 0x00);
|
||||
|
|
|
@ -713,7 +713,7 @@ static int controlfb_blank(int blank_mode, struct fb_info *info)
|
|||
break;
|
||||
case FB_BLANK_POWERDOWN:
|
||||
ctrl &= ~0x33;
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case FB_BLANK_NORMAL:
|
||||
ctrl |= 0x400;
|
||||
break;
|
||||
|
|
|
@ -1310,7 +1310,7 @@ static long fb_compat_ioctl(struct file *file, unsigned int cmd,
|
|||
case FBIOGET_CON2FBMAP:
|
||||
case FBIOPUT_CON2FBMAP:
|
||||
arg = (unsigned long) compat_ptr(arg);
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case FBIOBLANK:
|
||||
ret = do_fb_ioctl(info, cmd, arg);
|
||||
break;
|
||||
|
|
|
@ -1287,7 +1287,7 @@ static int fsl_diu_ioctl(struct fb_info *info, unsigned int cmd,
|
|||
dev_warn(info->dev,
|
||||
"MFB_SET_PIXFMT value of 0x%08x is deprecated.\n",
|
||||
MFB_SET_PIXFMT_OLD);
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case MFB_SET_PIXFMT:
|
||||
if (copy_from_user(&pix_fmt, buf, sizeof(pix_fmt)))
|
||||
return -EFAULT;
|
||||
|
@ -1297,7 +1297,7 @@ static int fsl_diu_ioctl(struct fb_info *info, unsigned int cmd,
|
|||
dev_warn(info->dev,
|
||||
"MFB_GET_PIXFMT value of 0x%08x is deprecated.\n",
|
||||
MFB_GET_PIXFMT_OLD);
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case MFB_GET_PIXFMT:
|
||||
pix_fmt = ad->pix_fmt;
|
||||
if (copy_to_user(buf, &pix_fmt, sizeof(pix_fmt)))
|
||||
|
|
|
@ -534,7 +534,7 @@ static int gxt4500_setcolreg(unsigned int reg, unsigned int red,
|
|||
break;
|
||||
case DFA_PIX_32BIT:
|
||||
val |= (reg << 24);
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case DFA_PIX_24BIT:
|
||||
val |= (reg << 16) | (reg << 8);
|
||||
break;
|
||||
|
|
|
@ -430,7 +430,7 @@ static int i740fb_decode_var(const struct fb_var_screeninfo *var,
|
|||
break;
|
||||
case 9 ... 15:
|
||||
bpp = 15;
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case 16:
|
||||
if ((1000000 / var->pixclock) > DACSPEED16) {
|
||||
dev_err(info->device, "requested pixclock %i MHz out of range (max. %i MHz at 15/16bpp)\n",
|
||||
|
|
|
@ -141,7 +141,7 @@ static int offb_setcolreg(u_int regno, u_int red, u_int green, u_int blue,
|
|||
/* Clear PALETTE_ACCESS_CNTL in DAC_CNTL */
|
||||
out_le32(par->cmap_adr + 0x58,
|
||||
in_le32(par->cmap_adr + 0x58) & ~0x20);
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case cmap_r128:
|
||||
/* Set palette index & data */
|
||||
out_8(par->cmap_adr + 0xb0, regno);
|
||||
|
@ -211,7 +211,7 @@ static int offb_blank(int blank, struct fb_info *info)
|
|||
/* Clear PALETTE_ACCESS_CNTL in DAC_CNTL */
|
||||
out_le32(par->cmap_adr + 0x58,
|
||||
in_le32(par->cmap_adr + 0x58) & ~0x20);
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case cmap_r128:
|
||||
/* Set palette index & data */
|
||||
out_8(par->cmap_adr + 0xb0, i);
|
||||
|
|
|
@ -328,13 +328,13 @@ static int omap_lcdc_setup_plane(int plane, int channel_out,
|
|||
lcdc.bpp = 12;
|
||||
break;
|
||||
}
|
||||
/* fallthrough */
|
||||
fallthrough;
|
||||
case OMAPFB_COLOR_YUV422:
|
||||
if (lcdc.ext_mode) {
|
||||
lcdc.bpp = 16;
|
||||
break;
|
||||
}
|
||||
/* fallthrough */
|
||||
fallthrough;
|
||||
default:
|
||||
/* FIXME: other BPPs.
|
||||
* bpp1: code 0, size 256
|
||||
|
|
|
@ -253,7 +253,7 @@ static int _setcolreg(struct fb_info *info, u_int regno, u_int red, u_int green,
|
|||
if (fbdev->ctrl->setcolreg)
|
||||
r = fbdev->ctrl->setcolreg(regno, red, green, blue,
|
||||
transp, update_hw_pal);
|
||||
/* Fallthrough */
|
||||
fallthrough;
|
||||
case OMAPFB_COLOR_RGB565:
|
||||
case OMAPFB_COLOR_RGB444:
|
||||
if (r != 0)
|
||||
|
@ -443,7 +443,7 @@ static int set_color_mode(struct omapfb_plane_struct *plane,
|
|||
return 0;
|
||||
case 12:
|
||||
var->bits_per_pixel = 16;
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case 16:
|
||||
if (plane->fbdev->panel->bpp == 12)
|
||||
plane->color_mode = OMAPFB_COLOR_RGB444;
|
||||
|
@ -1531,27 +1531,27 @@ static void omapfb_free_resources(struct omapfb_device *fbdev, int state)
|
|||
case OMAPFB_ACTIVE:
|
||||
for (i = 0; i < fbdev->mem_desc.region_cnt; i++)
|
||||
unregister_framebuffer(fbdev->fb_info[i]);
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case 7:
|
||||
omapfb_unregister_sysfs(fbdev);
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case 6:
|
||||
if (fbdev->panel->disable)
|
||||
fbdev->panel->disable(fbdev->panel);
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case 5:
|
||||
omapfb_set_update_mode(fbdev, OMAPFB_UPDATE_DISABLED);
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case 4:
|
||||
planes_cleanup(fbdev);
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case 3:
|
||||
ctrl_cleanup(fbdev);
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case 2:
|
||||
if (fbdev->panel->cleanup)
|
||||
fbdev->panel->cleanup(fbdev->panel);
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case 1:
|
||||
dev_set_drvdata(fbdev->dev, NULL);
|
||||
kfree(fbdev);
|
||||
|
@ -1854,7 +1854,7 @@ static int __init omapfb_setup(char *options)
|
|||
case 'm':
|
||||
case 'M':
|
||||
vram *= 1024;
|
||||
/* Fall through */
|
||||
fallthrough;
|
||||
case 'k':
|
||||
case 'K':
|
||||
vram *= 1024;
|
||||
|
|
|
@ -1861,7 +1861,7 @@ static void calc_vrfb_rotation_offset(u8 rotation, bool mirror,
|
|||
if (color_mode == OMAP_DSS_COLOR_YUV2 ||
|
||||
color_mode == OMAP_DSS_COLOR_UYVY)
|
||||
width = width >> 1;
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case OMAP_DSS_ROT_90:
|
||||
case OMAP_DSS_ROT_270:
|
||||
*offset1 = 0;
|
||||
|
@ -1884,7 +1884,7 @@ static void calc_vrfb_rotation_offset(u8 rotation, bool mirror,
|
|||
if (color_mode == OMAP_DSS_COLOR_YUV2 ||
|
||||
color_mode == OMAP_DSS_COLOR_UYVY)
|
||||
width = width >> 1;
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case OMAP_DSS_ROT_90 + 4:
|
||||
case OMAP_DSS_ROT_270 + 4:
|
||||
*offset1 = 0;
|
||||
|
|
|
@ -760,7 +760,7 @@ int omapfb_ioctl(struct fb_info *fbi, unsigned int cmd, unsigned long arg)
|
|||
r = -ENODEV;
|
||||
break;
|
||||
}
|
||||
/* FALLTHROUGH */
|
||||
fallthrough;
|
||||
|
||||
case OMAPFB_WAITFORVSYNC:
|
||||
DBG("ioctl WAITFORVSYNC\n");
|
||||
|
|
|
@ -882,7 +882,7 @@ int omapfb_setup_overlay(struct fb_info *fbi, struct omap_overlay *ovl,
|
|||
/ (var->bits_per_pixel >> 2);
|
||||
break;
|
||||
}
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
default:
|
||||
screen_width = fix->line_length / (var->bits_per_pixel >> 3);
|
||||
break;
|
||||
|
|
|
@ -233,10 +233,10 @@ static u32 to3264(u32 timing, int bpp, int is64)
|
|||
switch (bpp) {
|
||||
case 24:
|
||||
timing *= 3;
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case 8:
|
||||
timing >>= 1;
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case 16:
|
||||
timing >>= 1;
|
||||
case 32:
|
||||
|
|
|
@ -1614,7 +1614,7 @@ static void set_ctrlr_state(struct pxafb_info *fbi, u_int state)
|
|||
*/
|
||||
if (old_state != C_DISABLE_PM)
|
||||
break;
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
|
||||
case C_ENABLE:
|
||||
/*
|
||||
|
|
|
@ -284,7 +284,7 @@ static int s3c_fb_check_var(struct fb_var_screeninfo *var,
|
|||
/* 666 with one bit alpha/transparency */
|
||||
var->transp.offset = 18;
|
||||
var->transp.length = 1;
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case 18:
|
||||
var->bits_per_pixel = 32;
|
||||
|
||||
|
@ -312,7 +312,7 @@ static int s3c_fb_check_var(struct fb_var_screeninfo *var,
|
|||
case 25:
|
||||
var->transp.length = var->bits_per_pixel - 24;
|
||||
var->transp.offset = 24;
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case 24:
|
||||
/* our 24bpp is unpacked, so 32bpp */
|
||||
var->bits_per_pixel = 32;
|
||||
|
@ -809,7 +809,7 @@ static int s3c_fb_blank(int blank_mode, struct fb_info *info)
|
|||
case FB_BLANK_POWERDOWN:
|
||||
wincon &= ~WINCONx_ENWIN;
|
||||
sfb->enabled &= ~(1 << index);
|
||||
/* fall through - to FB_BLANK_NORMAL */
|
||||
fallthrough; /* to FB_BLANK_NORMAL */
|
||||
|
||||
case FB_BLANK_NORMAL:
|
||||
/* disable the DMA and display 0x0 (black) */
|
||||
|
|
|
@ -935,7 +935,7 @@ static void set_ctrlr_state(struct sa1100fb_info *fbi, u_int state)
|
|||
*/
|
||||
if (old_state != C_DISABLE_PM)
|
||||
break;
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
|
||||
case C_ENABLE:
|
||||
/*
|
||||
|
|
|
@ -1859,8 +1859,7 @@ static int savage_init_hw(struct savagefb_par *par)
|
|||
vga_out8(0x3d4, 0x68, par); /* memory control 1 */
|
||||
if ((vga_in8(0x3d5, par) & 0xC0) == (0x01 << 6))
|
||||
RamSavage4[1] = 8;
|
||||
|
||||
/*FALLTHROUGH*/
|
||||
fallthrough;
|
||||
|
||||
case S3_SAVAGE2000:
|
||||
videoRam = RamSavage4[(config1 & 0xE0) >> 5] * 1024;
|
||||
|
|
|
@ -1594,7 +1594,7 @@ sh_mobile_lcdc_overlay_fb_init(struct sh_mobile_lcdc_overlay *ovl)
|
|||
case V4L2_PIX_FMT_NV12:
|
||||
case V4L2_PIX_FMT_NV21:
|
||||
info->fix.ypanstep = 2;
|
||||
/* Fall through */
|
||||
fallthrough;
|
||||
case V4L2_PIX_FMT_NV16:
|
||||
case V4L2_PIX_FMT_NV61:
|
||||
info->fix.xpanstep = 2;
|
||||
|
@ -2085,7 +2085,7 @@ sh_mobile_lcdc_channel_fb_init(struct sh_mobile_lcdc_chan *ch,
|
|||
case V4L2_PIX_FMT_NV12:
|
||||
case V4L2_PIX_FMT_NV21:
|
||||
info->fix.ypanstep = 2;
|
||||
/* Fall through */
|
||||
fallthrough;
|
||||
case V4L2_PIX_FMT_NV16:
|
||||
case V4L2_PIX_FMT_NV61:
|
||||
info->fix.xpanstep = 2;
|
||||
|
|
|
@ -1005,7 +1005,7 @@ static int sm501fb_blank_crt(int blank_mode, struct fb_info *info)
|
|||
case FB_BLANK_POWERDOWN:
|
||||
ctrl &= ~SM501_DC_CRT_CONTROL_ENABLE;
|
||||
sm501_misc_control(fbi->dev->parent, SM501_MISC_DAC_POWER, 0);
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
|
||||
case FB_BLANK_NORMAL:
|
||||
ctrl |= SM501_DC_CRT_CONTROL_BLANK;
|
||||
|
|
|
@ -523,7 +523,7 @@ static int tdfxfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
|
|||
case 32:
|
||||
var->transp.offset = 24;
|
||||
var->transp.length = 8;
|
||||
/* fall through */
|
||||
fallthrough;
|
||||
case 24:
|
||||
var->red.offset = 16;
|
||||
var->green.offset = 8;
|
||||
|
|
|
@ -677,7 +677,7 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
|
|||
case XenbusStateClosed:
|
||||
if (dev->state == XenbusStateClosed)
|
||||
break;
|
||||
/* fall through - Missed the backend's CLOSING state. */
|
||||
fallthrough; /* Missed the backend's CLOSING state */
|
||||
case XenbusStateClosing:
|
||||
xenbus_frontend_closed(dev);
|
||||
break;
|
||||
|
|
Загрузка…
Ссылка в новой задаче