kill-the-bkl/reiserfs: fix "reiserfs lock" / "inode mutex" lock inversion dependency
reiserfs_xattr_init is called with the reiserfs write lock held, but if the ".reiserfs_priv" entry is not created, we take the superblock root directory inode mutex until .reiserfs_priv is created. This creates a lock dependency inversion against other sites such as reiserfs_file_release() which takes an inode mutex and the reiserfs lock after. Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> Cc: Jeff Mahoney <jeffm@suse.com> Cc: Chris Mason <chris.mason@oracle.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Alexander Beregalov <a.beregalov@gmail.com> Cc: Laurent Riffard <laurent.riffard@free.fr>
This commit is contained in:
Родитель
08f14fc896
Коммит
ae635c0bbd
|
@ -1004,7 +1004,7 @@ int reiserfs_xattr_init(struct super_block *s, int mount_flags)
|
|||
goto error;
|
||||
|
||||
if (!privroot->d_inode && !(mount_flags & MS_RDONLY)) {
|
||||
mutex_lock(&s->s_root->d_inode->i_mutex);
|
||||
reiserfs_mutex_lock_safe(&s->s_root->d_inode->i_mutex, s);
|
||||
err = create_privroot(REISERFS_SB(s)->priv_root);
|
||||
mutex_unlock(&s->s_root->d_inode->i_mutex);
|
||||
}
|
||||
|
|
Загрузка…
Ссылка в новой задаче