net: bridge: mcast: toggle also host vlan state in br_multicast_toggle_vlan
When changing vlan mcast state by br_multicast_toggle_vlan it iterates
over all ports and enables/disables the port mcast ctx based on the new
state, but I forgot to update the host vlan (bridge master vlan entry)
with the new state so it will be left out. Also that function is not
used outside of br_multicast.c, so make it static.
Fixes: f4b7002a70
("net: bridge: add vlan mcast snooping knob")
Signed-off-by: Nikolay Aleksandrov <nikolay@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Родитель
3f0d14efe2
Коммит
affce9a774
|
@ -4074,7 +4074,7 @@ void br_multicast_toggle_one_vlan(struct net_bridge_vlan *vlan, bool on)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
void br_multicast_toggle_vlan(struct net_bridge_vlan *vlan, bool on)
|
static void br_multicast_toggle_vlan(struct net_bridge_vlan *vlan, bool on)
|
||||||
{
|
{
|
||||||
struct net_bridge_port *p;
|
struct net_bridge_port *p;
|
||||||
|
|
||||||
|
@ -4089,6 +4089,9 @@ void br_multicast_toggle_vlan(struct net_bridge_vlan *vlan, bool on)
|
||||||
continue;
|
continue;
|
||||||
br_multicast_toggle_one_vlan(vport, on);
|
br_multicast_toggle_one_vlan(vport, on);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (br_vlan_is_brentry(vlan))
|
||||||
|
br_multicast_toggle_one_vlan(vlan, on);
|
||||||
}
|
}
|
||||||
|
|
||||||
int br_multicast_toggle_vlan_snooping(struct net_bridge *br, bool on,
|
int br_multicast_toggle_vlan_snooping(struct net_bridge *br, bool on,
|
||||||
|
|
|
@ -938,7 +938,6 @@ void br_multicast_port_ctx_init(struct net_bridge_port *port,
|
||||||
struct net_bridge_mcast_port *pmctx);
|
struct net_bridge_mcast_port *pmctx);
|
||||||
void br_multicast_port_ctx_deinit(struct net_bridge_mcast_port *pmctx);
|
void br_multicast_port_ctx_deinit(struct net_bridge_mcast_port *pmctx);
|
||||||
void br_multicast_toggle_one_vlan(struct net_bridge_vlan *vlan, bool on);
|
void br_multicast_toggle_one_vlan(struct net_bridge_vlan *vlan, bool on);
|
||||||
void br_multicast_toggle_vlan(struct net_bridge_vlan *vlan, bool on);
|
|
||||||
int br_multicast_toggle_vlan_snooping(struct net_bridge *br, bool on,
|
int br_multicast_toggle_vlan_snooping(struct net_bridge *br, bool on,
|
||||||
struct netlink_ext_ack *extack);
|
struct netlink_ext_ack *extack);
|
||||||
bool br_multicast_toggle_global_vlan(struct net_bridge_vlan *vlan, bool on);
|
bool br_multicast_toggle_global_vlan(struct net_bridge_vlan *vlan, bool on);
|
||||||
|
@ -1370,11 +1369,6 @@ static inline void br_multicast_toggle_one_vlan(struct net_bridge_vlan *vlan,
|
||||||
{
|
{
|
||||||
}
|
}
|
||||||
|
|
||||||
static inline void br_multicast_toggle_vlan(struct net_bridge_vlan *vlan,
|
|
||||||
bool on)
|
|
||||||
{
|
|
||||||
}
|
|
||||||
|
|
||||||
static inline int br_multicast_toggle_vlan_snooping(struct net_bridge *br,
|
static inline int br_multicast_toggle_vlan_snooping(struct net_bridge *br,
|
||||||
bool on,
|
bool on,
|
||||||
struct netlink_ext_ack *extack)
|
struct netlink_ext_ack *extack)
|
||||||
|
|
Загрузка…
Ссылка в новой задаче