crypto: hifn_795x - Pass correct pointer to free_irq()
free_irq() expects the same pointer that was passed to request_irq(), otherwise the IRQ is not freed. The issue was found using the following coccinelle script: <smpl> @r1@ type T; T devid; @@ request_irq(..., devid) @r2@ type r1.T; T devid; position p; @@ free_irq@p(..., devid) @@ position p != r2.p; @@ *free_irq@p(...) </smpl> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Родитель
519d8b1a9d
Коммит
b02266531f
|
@ -2676,7 +2676,7 @@ err_out_stop_device:
|
|||
hifn_reset_dma(dev, 1);
|
||||
hifn_stop_device(dev);
|
||||
err_out_free_irq:
|
||||
free_irq(dev->irq, dev->name);
|
||||
free_irq(dev->irq, dev);
|
||||
tasklet_kill(&dev->tasklet);
|
||||
err_out_free_desc:
|
||||
pci_free_consistent(pdev, sizeof(struct hifn_dma),
|
||||
|
@ -2711,7 +2711,7 @@ static void hifn_remove(struct pci_dev *pdev)
|
|||
hifn_reset_dma(dev, 1);
|
||||
hifn_stop_device(dev);
|
||||
|
||||
free_irq(dev->irq, dev->name);
|
||||
free_irq(dev->irq, dev);
|
||||
tasklet_kill(&dev->tasklet);
|
||||
|
||||
hifn_flush(dev);
|
||||
|
|
Загрузка…
Ссылка в новой задаче