drm/mediatek: avoid dereferencing a null hdmi_phy on an error message
Currently there is a null pointer check for hdmi_phy that implies it
may be null, however a dev_err messages dereferences this potential null
pointer. Avoid a null pointer dereference by only emitting the dev_err
message if hdmi_phy is non-null. It is a moot point if the error message
needs to be printed at all, but since this is a relatively new piece of
code it may be useful to keep the message in for the moment in case there
are unforseen errors that need to be reported.
Fixes: be28b6507c
("drm/mediatek: separate hdmi phy to different file")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Dereference after null check")
Link: https://lore.kernel.org/r/20201207150937.170435-1-colin.king@canonical.com
[vkoul: fix indent of return call]
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Родитель
1dfd7b7849
Коммит
b097efba95
|
@ -84,8 +84,9 @@ mtk_hdmi_phy_dev_get_ops(const struct mtk_hdmi_phy *hdmi_phy)
|
|||
hdmi_phy->conf->hdmi_phy_disable_tmds)
|
||||
return &mtk_hdmi_phy_dev_ops;
|
||||
|
||||
dev_err(hdmi_phy->dev, "Failed to get dev ops of phy\n");
|
||||
return NULL;
|
||||
if (hdmi_phy)
|
||||
dev_err(hdmi_phy->dev, "Failed to get dev ops of phy\n");
|
||||
return NULL;
|
||||
}
|
||||
|
||||
static void mtk_hdmi_phy_clk_get_data(struct mtk_hdmi_phy *hdmi_phy,
|
||||
|
|
Загрузка…
Ссылка в новой задаче