PCI: exynos: Don't discard .remove() callback

commit 83a939f0fdc208ff3639dd3d42ac9b3c35607fd2 upstream.

With CONFIG_PCI_EXYNOS=y and exynos_pcie_remove() marked with __exit, the
function is discarded from the driver. In this case a bound device can
still get unbound, e.g via sysfs. Then no cleanup code is run resulting in
resource leaks or worse.

The right thing to do is do always have the remove callback available.
This fixes the following warning by modpost:

  WARNING: modpost: drivers/pci/controller/dwc/pci-exynos: section mismatch in reference: exynos_pcie_driver+0x8 (section: .data) -> exynos_pcie_remove (section: .exit.text)

(with ARCH=x86_64 W=1 allmodconfig).

Fixes: 340cba6092 ("pci: Add PCIe driver for Samsung Exynos")
Link: https://lore.kernel.org/r/20231001170254.2506508-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Uwe Kleine-König 2023-10-01 19:02:51 +02:00 коммит произвёл Greg Kroah-Hartman
Родитель f887967210
Коммит b156f62f19
1 изменённых файлов: 2 добавлений и 2 удалений

Просмотреть файл

@ -377,7 +377,7 @@ fail_probe:
return ret; return ret;
} }
static int __exit exynos_pcie_remove(struct platform_device *pdev) static int exynos_pcie_remove(struct platform_device *pdev)
{ {
struct exynos_pcie *ep = platform_get_drvdata(pdev); struct exynos_pcie *ep = platform_get_drvdata(pdev);
@ -433,7 +433,7 @@ static const struct of_device_id exynos_pcie_of_match[] = {
static struct platform_driver exynos_pcie_driver = { static struct platform_driver exynos_pcie_driver = {
.probe = exynos_pcie_probe, .probe = exynos_pcie_probe,
.remove = __exit_p(exynos_pcie_remove), .remove = exynos_pcie_remove,
.driver = { .driver = {
.name = "exynos-pcie", .name = "exynos-pcie",
.of_match_table = exynos_pcie_of_match, .of_match_table = exynos_pcie_of_match,