drivers/net: Use memdup_user
Use memdup_user when user data is immediately copied into the allocated region. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression from,to,size,flag; position p; identifier l1,l2; @@ - to = \(kmalloc@p\|kzalloc@p\)(size,flag); + to = memdup_user(from,size); if ( - to==NULL + IS_ERR(to) || ...) { <+... when != goto l1; - -ENOMEM + PTR_ERR(to) ...+> } - if (copy_from_user(to, from, size) != 0) { - <+... when != goto l2; - -EFAULT - ...+> - } // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Родитель
16dff91804
Коммит
b23d00e921
|
@ -538,14 +538,9 @@ static int get_filter(void __user *arg, struct sock_filter **p)
|
|||
}
|
||||
|
||||
len = uprog.len * sizeof(struct sock_filter);
|
||||
code = kmalloc(len, GFP_KERNEL);
|
||||
if (code == NULL)
|
||||
return -ENOMEM;
|
||||
|
||||
if (copy_from_user(code, uprog.filter, len)) {
|
||||
kfree(code);
|
||||
return -EFAULT;
|
||||
}
|
||||
code = memdup_user(uprog.filter, len);
|
||||
if (IS_ERR(code))
|
||||
return PTR_ERR(code);
|
||||
|
||||
err = sk_chk_filter(code, uprog.len);
|
||||
if (err) {
|
||||
|
|
Загрузка…
Ссылка в новой задаче