dm integrity: fix out-of-range warning
[ Upstream commit 8e91c2342351e0f5ef6c0a704384a7f6fc70c3b2 ]
Depending on the value of CONFIG_HZ, clang complains about a pointless
comparison:
drivers/md/dm-integrity.c:4085:12: error: result of comparison of
constant 42949672950 with expression of type
'unsigned int' is always false
[-Werror,-Wtautological-constant-out-of-range-compare]
if (val >= (uint64_t)UINT_MAX * 1000 / HZ) {
As the check remains useful for other configurations, shut up the
warning by adding a second type cast to uint64_t.
Fixes: 468dfca38b
("dm integrity: add a bitmap mode")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Mikulas Patocka <mpatocka@redhat.com>
Reviewed-by: Justin Stitt <justinstitt@google.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Родитель
bef3bc962d
Коммит
b8438db837
|
@ -4083,7 +4083,7 @@ static int dm_integrity_ctr(struct dm_target *ti, unsigned argc, char **argv)
|
||||||
} else if (sscanf(opt_string, "sectors_per_bit:%llu%c", &llval, &dummy) == 1) {
|
} else if (sscanf(opt_string, "sectors_per_bit:%llu%c", &llval, &dummy) == 1) {
|
||||||
log2_sectors_per_bitmap_bit = !llval ? 0 : __ilog2_u64(llval);
|
log2_sectors_per_bitmap_bit = !llval ? 0 : __ilog2_u64(llval);
|
||||||
} else if (sscanf(opt_string, "bitmap_flush_interval:%u%c", &val, &dummy) == 1) {
|
} else if (sscanf(opt_string, "bitmap_flush_interval:%u%c", &val, &dummy) == 1) {
|
||||||
if (val >= (uint64_t)UINT_MAX * 1000 / HZ) {
|
if ((uint64_t)val >= (uint64_t)UINT_MAX * 1000 / HZ) {
|
||||||
r = -EINVAL;
|
r = -EINVAL;
|
||||||
ti->error = "Invalid bitmap_flush_interval argument";
|
ti->error = "Invalid bitmap_flush_interval argument";
|
||||||
goto bad;
|
goto bad;
|
||||||
|
|
Загрузка…
Ссылка в новой задаче