ipv6: gre: fix ip6gre_err()
ip6gre_err() miscomputes grehlen (sizeof(ipv6h) is 4 or 8, not 40 as expected), and should take into account 'offset' parameter. Also uses pskb_may_pull() to cope with some fragged skbs Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Dmitry Kozlov <xeb@mail.ru> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Родитель
ef8531b64c
Коммит
b87fb39e39
|
@ -415,8 +415,8 @@ static void ip6gre_err(struct sk_buff *skb, struct inet6_skb_parm *opt,
|
||||||
u8 type, u8 code, int offset, __be32 info)
|
u8 type, u8 code, int offset, __be32 info)
|
||||||
{
|
{
|
||||||
const struct ipv6hdr *ipv6h = (const struct ipv6hdr *)skb->data;
|
const struct ipv6hdr *ipv6h = (const struct ipv6hdr *)skb->data;
|
||||||
__be16 *p = (__be16 *)(ipv6h + 1);
|
__be16 *p = (__be16 *)(skb->data + offset);
|
||||||
int grehlen = sizeof(ipv6h) + 4;
|
int grehlen = offset + 4;
|
||||||
struct ip6_tnl *t;
|
struct ip6_tnl *t;
|
||||||
__be16 flags;
|
__be16 flags;
|
||||||
|
|
||||||
|
@ -432,8 +432,10 @@ static void ip6gre_err(struct sk_buff *skb, struct inet6_skb_parm *opt,
|
||||||
}
|
}
|
||||||
|
|
||||||
/* If only 8 bytes returned, keyed message will be dropped here */
|
/* If only 8 bytes returned, keyed message will be dropped here */
|
||||||
if (skb_headlen(skb) < grehlen)
|
if (!pskb_may_pull(skb, grehlen))
|
||||||
return;
|
return;
|
||||||
|
ipv6h = (const struct ipv6hdr *)skb->data;
|
||||||
|
p = (__be16 *)(skb->data + offset);
|
||||||
|
|
||||||
rcu_read_lock();
|
rcu_read_lock();
|
||||||
|
|
||||||
|
|
Загрузка…
Ссылка в новой задаче