ALSA: hda/via: Avoid potential array out-of-bound in add_secret_dac_path()
snd_hda_get_connections() can return a negative error code.
It may lead to accessing 'conn' array at a negative index.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Artemii Karasev <karasev@ispras.ru>
Fixes: 30b4503378
("ALSA: hda - Expose secret DAC-AA connection of some VIA codecs")
Link: https://lore.kernel.org/r/20230119082259.3634-1-karasev@ispras.ru
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Родитель
dfd5fe19db
Коммит
b9cee506da
|
@ -819,6 +819,9 @@ static int add_secret_dac_path(struct hda_codec *codec)
|
|||
return 0;
|
||||
nums = snd_hda_get_connections(codec, spec->gen.mixer_nid, conn,
|
||||
ARRAY_SIZE(conn) - 1);
|
||||
if (nums < 0)
|
||||
return nums;
|
||||
|
||||
for (i = 0; i < nums; i++) {
|
||||
if (get_wcaps_type(get_wcaps(codec, conn[i])) == AC_WID_AUD_OUT)
|
||||
return 0;
|
||||
|
|
Загрузка…
Ссылка в новой задаче