ACPI / hotplug: Simplify acpi_set_hp_context()
Since all of the acpi_set_hp_context() callers pass at least one NULL function pointer and one caller passes NULL function pointers only to it, drop function pointer arguments from acpi_set_hp_context() and make the callers initialize the function pointers in struct acpi_hotplug_context by themselves before passing it to acpi_set_hp_context(). Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
This commit is contained in:
Родитель
86f5f3ca49
Коммит
ba574dc856
|
@ -77,7 +77,9 @@ void acpi_initialize_hp_context(struct acpi_device *adev,
|
||||||
void (*uevent)(struct acpi_device *, u32))
|
void (*uevent)(struct acpi_device *, u32))
|
||||||
{
|
{
|
||||||
acpi_lock_hp_context();
|
acpi_lock_hp_context();
|
||||||
acpi_set_hp_context(adev, hp, notify, uevent, NULL);
|
hp->notify = notify;
|
||||||
|
hp->uevent = uevent;
|
||||||
|
acpi_set_hp_context(adev, hp);
|
||||||
acpi_unlock_hp_context();
|
acpi_unlock_hp_context();
|
||||||
}
|
}
|
||||||
EXPORT_SYMBOL_GPL(acpi_initialize_hp_context);
|
EXPORT_SYMBOL_GPL(acpi_initialize_hp_context);
|
||||||
|
|
|
@ -80,8 +80,9 @@ static struct acpiphp_context *acpiphp_init_context(struct acpi_device *adev)
|
||||||
return NULL;
|
return NULL;
|
||||||
|
|
||||||
context->refcount = 1;
|
context->refcount = 1;
|
||||||
acpi_set_hp_context(adev, &context->hp, acpiphp_hotplug_notify, NULL,
|
context->hp.notify = acpiphp_hotplug_notify;
|
||||||
acpiphp_post_dock_fixup);
|
context->hp.fixup = acpiphp_post_dock_fixup;
|
||||||
|
acpi_set_hp_context(adev, &context->hp);
|
||||||
return context;
|
return context;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -876,7 +877,7 @@ void acpiphp_enumerate_slots(struct pci_bus *bus)
|
||||||
goto err;
|
goto err;
|
||||||
|
|
||||||
root_context->root_bridge = bridge;
|
root_context->root_bridge = bridge;
|
||||||
acpi_set_hp_context(adev, &root_context->hp, NULL, NULL, NULL);
|
acpi_set_hp_context(adev, &root_context->hp);
|
||||||
} else {
|
} else {
|
||||||
struct acpiphp_context *context;
|
struct acpiphp_context *context;
|
||||||
|
|
||||||
|
|
|
@ -372,15 +372,9 @@ static inline void acpi_set_device_status(struct acpi_device *adev, u32 sta)
|
||||||
}
|
}
|
||||||
|
|
||||||
static inline void acpi_set_hp_context(struct acpi_device *adev,
|
static inline void acpi_set_hp_context(struct acpi_device *adev,
|
||||||
struct acpi_hotplug_context *hp,
|
struct acpi_hotplug_context *hp)
|
||||||
int (*notify)(struct acpi_device *, u32),
|
|
||||||
void (*uevent)(struct acpi_device *, u32),
|
|
||||||
void (*fixup)(struct acpi_device *))
|
|
||||||
{
|
{
|
||||||
hp->self = adev;
|
hp->self = adev;
|
||||||
hp->notify = notify;
|
|
||||||
hp->uevent = uevent;
|
|
||||||
hp->fixup = fixup;
|
|
||||||
adev->hp = hp;
|
adev->hp = hp;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Загрузка…
Ссылка в новой задаче