ext4: Change the default behaviour on error
ext4 file system was by default ignoring errors and continuing. This is not a good default as continuing on error could lead to file system corruption. Change the default to mark the file system readonly. Debian and ubuntu already does this as the default in their fstab. Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> Acked-by: Eric Sandeen <sandeen@redhat.com> Signed-off-by: Mingming Cao <cmm@us.ibm.com>
This commit is contained in:
Родитель
e7c9559300
Коммит
bb4f397a1a
|
@ -688,16 +688,16 @@ static int ext4_show_options(struct seq_file *seq, struct vfsmount *vfs)
|
|||
le16_to_cpu(es->s_def_resgid) != EXT4_DEF_RESGID) {
|
||||
seq_printf(seq, ",resgid=%u", sbi->s_resgid);
|
||||
}
|
||||
if (test_opt(sb, ERRORS_CONT)) {
|
||||
if (test_opt(sb, ERRORS_RO)) {
|
||||
int def_errors = le16_to_cpu(es->s_errors);
|
||||
|
||||
if (def_errors == EXT4_ERRORS_PANIC ||
|
||||
def_errors == EXT4_ERRORS_RO) {
|
||||
seq_puts(seq, ",errors=continue");
|
||||
def_errors == EXT4_ERRORS_CONTINUE) {
|
||||
seq_puts(seq, ",errors=remount-ro");
|
||||
}
|
||||
}
|
||||
if (test_opt(sb, ERRORS_RO))
|
||||
seq_puts(seq, ",errors=remount-ro");
|
||||
if (test_opt(sb, ERRORS_CONT))
|
||||
seq_puts(seq, ",errors=continue");
|
||||
if (test_opt(sb, ERRORS_PANIC))
|
||||
seq_puts(seq, ",errors=panic");
|
||||
if (test_opt(sb, NO_UID32))
|
||||
|
@ -1819,10 +1819,10 @@ static int ext4_fill_super (struct super_block *sb, void *data, int silent)
|
|||
|
||||
if (le16_to_cpu(sbi->s_es->s_errors) == EXT4_ERRORS_PANIC)
|
||||
set_opt(sbi->s_mount_opt, ERRORS_PANIC);
|
||||
else if (le16_to_cpu(sbi->s_es->s_errors) == EXT4_ERRORS_RO)
|
||||
set_opt(sbi->s_mount_opt, ERRORS_RO);
|
||||
else
|
||||
else if (le16_to_cpu(sbi->s_es->s_errors) == EXT4_ERRORS_CONTINUE)
|
||||
set_opt(sbi->s_mount_opt, ERRORS_CONT);
|
||||
else
|
||||
set_opt(sbi->s_mount_opt, ERRORS_RO);
|
||||
|
||||
sbi->s_resuid = le16_to_cpu(es->s_def_resuid);
|
||||
sbi->s_resgid = le16_to_cpu(es->s_def_resgid);
|
||||
|
|
Загрузка…
Ссылка в новой задаче