auxdisplay: ht16k33: do not try to free fbdev
'fbdev' is allocated as part of larger ht16k33_priv structure; trying to free it will cause troubles. Acked-by: Robin van der Gracht <robin@protonic.nl> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
372b1e9134
Коммит
bbd39d1e4a
|
@ -378,7 +378,7 @@ static int ht16k33_probe(struct i2c_client *client,
|
||||||
fbdev->buffer = (unsigned char *) get_zeroed_page(GFP_KERNEL);
|
fbdev->buffer = (unsigned char *) get_zeroed_page(GFP_KERNEL);
|
||||||
if (!fbdev->buffer) {
|
if (!fbdev->buffer) {
|
||||||
err = -ENOMEM;
|
err = -ENOMEM;
|
||||||
goto err_free_fbdev;
|
goto err_destroy_wq;
|
||||||
}
|
}
|
||||||
|
|
||||||
fbdev->cache = devm_kmalloc(&client->dev, HT16K33_FB_SIZE, GFP_KERNEL);
|
fbdev->cache = devm_kmalloc(&client->dev, HT16K33_FB_SIZE, GFP_KERNEL);
|
||||||
|
@ -510,8 +510,6 @@ err_fbdev_info:
|
||||||
framebuffer_release(fbdev->info);
|
framebuffer_release(fbdev->info);
|
||||||
err_fbdev_buffer:
|
err_fbdev_buffer:
|
||||||
free_page((unsigned long) fbdev->buffer);
|
free_page((unsigned long) fbdev->buffer);
|
||||||
err_free_fbdev:
|
|
||||||
kfree(fbdev);
|
|
||||||
err_destroy_wq:
|
err_destroy_wq:
|
||||||
destroy_workqueue(priv->workqueue);
|
destroy_workqueue(priv->workqueue);
|
||||||
|
|
||||||
|
|
Загрузка…
Ссылка в новой задаче