hvc_dcc: Simplify put_chars()/get_chars() loops
Casting and anding with 0xff is unnecessary in hvc_dcc_put_chars() since buf is already a char[]. __dcc_get_char() can't return an int less than 0 since it only returns a char. Simplify the if statement in hvc_dcc_get_chars() to take this into account. Cc: Daniel Walker <dwalker@codeaurora.org> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Родитель
a996320146
Коммит
bf73bd35a2
|
@ -89,7 +89,7 @@ static int hvc_dcc_put_chars(uint32_t vt, const char *buf, int count)
|
||||||
while (__dcc_getstatus() & DCC_STATUS_TX)
|
while (__dcc_getstatus() & DCC_STATUS_TX)
|
||||||
cpu_relax();
|
cpu_relax();
|
||||||
|
|
||||||
__dcc_putchar((char)(buf[i] & 0xFF));
|
__dcc_putchar(buf[i]);
|
||||||
}
|
}
|
||||||
|
|
||||||
return count;
|
return count;
|
||||||
|
@ -99,15 +99,11 @@ static int hvc_dcc_get_chars(uint32_t vt, char *buf, int count)
|
||||||
{
|
{
|
||||||
int i;
|
int i;
|
||||||
|
|
||||||
for (i = 0; i < count; ++i) {
|
for (i = 0; i < count; ++i)
|
||||||
int c = -1;
|
|
||||||
|
|
||||||
if (__dcc_getstatus() & DCC_STATUS_RX)
|
if (__dcc_getstatus() & DCC_STATUS_RX)
|
||||||
c = __dcc_getchar();
|
buf[i] = __dcc_getchar();
|
||||||
if (c < 0)
|
else
|
||||||
break;
|
break;
|
||||||
buf[i] = c;
|
|
||||||
}
|
|
||||||
|
|
||||||
return i;
|
return i;
|
||||||
}
|
}
|
||||||
|
|
Загрузка…
Ссылка в новой задаче