ipmi:sm: Print current state when the state is invalid
Print current state before returning IPMI_NOT_IN_MY_STATE_ERR so we can know where this issue is coming from and possibly fix the state machine. Signed-off-by: Xianting Tian <tian.xianting@h3c.com> Message-Id: <20200915074441.4090-1-tian.xianting@h3c.com> [Converted printk() to pr_xxx().] Signed-off-by: Corey Minyard <cminyard@mvista.com>
This commit is contained in:
Родитель
81e7571ea3
Коммит
c2b1e76d8c
|
@ -213,8 +213,10 @@ static int bt_start_transaction(struct si_sm_data *bt,
|
||||||
if (bt->state == BT_STATE_LONG_BUSY)
|
if (bt->state == BT_STATE_LONG_BUSY)
|
||||||
return IPMI_NODE_BUSY_ERR;
|
return IPMI_NODE_BUSY_ERR;
|
||||||
|
|
||||||
if (bt->state != BT_STATE_IDLE)
|
if (bt->state != BT_STATE_IDLE) {
|
||||||
|
dev_warn(bt->io->dev, "BT is now in the state %d\n", bt->state);
|
||||||
return IPMI_NOT_IN_MY_STATE_ERR;
|
return IPMI_NOT_IN_MY_STATE_ERR;
|
||||||
|
}
|
||||||
|
|
||||||
if (bt_debug & BT_DEBUG_MSG) {
|
if (bt_debug & BT_DEBUG_MSG) {
|
||||||
dev_dbg(bt->io->dev, "+++++++++++++++++ New command\n");
|
dev_dbg(bt->io->dev, "+++++++++++++++++ New command\n");
|
||||||
|
|
|
@ -268,8 +268,10 @@ static int start_kcs_transaction(struct si_sm_data *kcs, unsigned char *data,
|
||||||
if (size > MAX_KCS_WRITE_SIZE)
|
if (size > MAX_KCS_WRITE_SIZE)
|
||||||
return IPMI_REQ_LEN_EXCEEDED_ERR;
|
return IPMI_REQ_LEN_EXCEEDED_ERR;
|
||||||
|
|
||||||
if ((kcs->state != KCS_IDLE) && (kcs->state != KCS_HOSED))
|
if ((kcs->state != KCS_IDLE) && (kcs->state != KCS_HOSED)) {
|
||||||
|
pr_warn("KCS is now in the state %d\n", kcs->state);
|
||||||
return IPMI_NOT_IN_MY_STATE_ERR;
|
return IPMI_NOT_IN_MY_STATE_ERR;
|
||||||
|
}
|
||||||
|
|
||||||
if (kcs_debug & KCS_DEBUG_MSG) {
|
if (kcs_debug & KCS_DEBUG_MSG) {
|
||||||
printk(KERN_DEBUG "start_kcs_transaction -");
|
printk(KERN_DEBUG "start_kcs_transaction -");
|
||||||
|
|
|
@ -126,8 +126,10 @@ static int start_smic_transaction(struct si_sm_data *smic,
|
||||||
if (size > MAX_SMIC_WRITE_SIZE)
|
if (size > MAX_SMIC_WRITE_SIZE)
|
||||||
return IPMI_REQ_LEN_EXCEEDED_ERR;
|
return IPMI_REQ_LEN_EXCEEDED_ERR;
|
||||||
|
|
||||||
if ((smic->state != SMIC_IDLE) && (smic->state != SMIC_HOSED))
|
if ((smic->state != SMIC_IDLE) && (smic->state != SMIC_HOSED)) {
|
||||||
|
pr_warn("SMIC is now in the state %d\n", smic->state);
|
||||||
return IPMI_NOT_IN_MY_STATE_ERR;
|
return IPMI_NOT_IN_MY_STATE_ERR;
|
||||||
|
}
|
||||||
|
|
||||||
if (smic_debug & SMIC_DEBUG_MSG) {
|
if (smic_debug & SMIC_DEBUG_MSG) {
|
||||||
printk(KERN_DEBUG "start_smic_transaction -");
|
printk(KERN_DEBUG "start_smic_transaction -");
|
||||||
|
|
Загрузка…
Ссылка в новой задаче