staging: mt7621-pinctrl: Add of_node_put() before return
Each iteration of for_each_compatible_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Add an of_node_put before the return. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> Link: https://lore.kernel.org/r/20190716055908.3183-1-nishkadg.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
2125a44149
Коммит
c4011dde24
|
@ -358,12 +358,15 @@ static int rt2880_pinmux_probe(struct platform_device *pdev)
|
|||
gpiobase = of_get_property(np, "ralink,gpio-base", NULL);
|
||||
if (!ngpio || !gpiobase) {
|
||||
dev_err(&pdev->dev, "failed to load chip info\n");
|
||||
of_node_put(np);
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
range = devm_kzalloc(p->dev, sizeof(*range), GFP_KERNEL);
|
||||
if (!range)
|
||||
if (!range) {
|
||||
of_node_put(np);
|
||||
return -ENOMEM;
|
||||
}
|
||||
range->name = "pio";
|
||||
range->npins = __be32_to_cpu(*ngpio);
|
||||
range->base = __be32_to_cpu(*gpiobase);
|
||||
|
|
Загрузка…
Ссылка в новой задаче