spi: rpc-if: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230303172041.2103336-61-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Uwe Kleine-König 2023-03-03 18:20:14 +01:00 коммит произвёл Mark Brown
Родитель 5ff5e67620
Коммит c42ee93ade
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 24D68B725D5487D0
1 изменённых файлов: 2 добавлений и 4 удалений

Просмотреть файл

@ -173,15 +173,13 @@ out_disable_rpm:
return error; return error;
} }
static int rpcif_spi_remove(struct platform_device *pdev) static void rpcif_spi_remove(struct platform_device *pdev)
{ {
struct spi_controller *ctlr = platform_get_drvdata(pdev); struct spi_controller *ctlr = platform_get_drvdata(pdev);
struct rpcif *rpc = spi_controller_get_devdata(ctlr); struct rpcif *rpc = spi_controller_get_devdata(ctlr);
spi_unregister_controller(ctlr); spi_unregister_controller(ctlr);
pm_runtime_disable(rpc->dev); pm_runtime_disable(rpc->dev);
return 0;
} }
static int __maybe_unused rpcif_spi_suspend(struct device *dev) static int __maybe_unused rpcif_spi_suspend(struct device *dev)
@ -202,7 +200,7 @@ static SIMPLE_DEV_PM_OPS(rpcif_spi_pm_ops, rpcif_spi_suspend, rpcif_spi_resume);
static struct platform_driver rpcif_spi_driver = { static struct platform_driver rpcif_spi_driver = {
.probe = rpcif_spi_probe, .probe = rpcif_spi_probe,
.remove = rpcif_spi_remove, .remove_new = rpcif_spi_remove,
.driver = { .driver = {
.name = "rpc-if-spi", .name = "rpc-if-spi",
#ifdef CONFIG_PM_SLEEP #ifdef CONFIG_PM_SLEEP