amd-xgbe: fix a couple timeout loops
At the end of the loop we test "if (!count)" but because "count--" is
a post-op then the loop will end with count set to -1. I have fixed
this by changing it to --count.
Fixes: c5aa9e3b81
('amd-xgbe: Initial AMD 10GbE platform driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Родитель
40d24c4d8a
Коммит
c7557e6a56
|
@ -1849,7 +1849,7 @@ static int xgbe_exit(struct xgbe_prv_data *pdata)
|
|||
usleep_range(10, 15);
|
||||
|
||||
/* Poll Until Poll Condition */
|
||||
while (count-- && XGMAC_IOREAD_BITS(pdata, DMA_MR, SWR))
|
||||
while (--count && XGMAC_IOREAD_BITS(pdata, DMA_MR, SWR))
|
||||
usleep_range(500, 600);
|
||||
|
||||
if (!count)
|
||||
|
@ -1873,7 +1873,7 @@ static int xgbe_flush_tx_queues(struct xgbe_prv_data *pdata)
|
|||
/* Poll Until Poll Condition */
|
||||
for (i = 0; i < pdata->tx_q_count; i++) {
|
||||
count = 2000;
|
||||
while (count-- && XGMAC_MTL_IOREAD_BITS(pdata, i,
|
||||
while (--count && XGMAC_MTL_IOREAD_BITS(pdata, i,
|
||||
MTL_Q_TQOMR, FTQ))
|
||||
usleep_range(500, 600);
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче