phy: rockchip: phy-rockchip-inno-hdmi: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Heiko Stuebner <heiko@sntech.de> Link: https://lore.kernel.org/r/20230307115900.2293120-22-u.kleine-koenig@pengutronix.de Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Родитель
497a38322a
Коммит
cb1161c0c1
|
@ -1246,11 +1246,9 @@ static int inno_hdmi_phy_probe(struct platform_device *pdev)
|
|||
return PTR_ERR_OR_ZERO(phy_provider);
|
||||
}
|
||||
|
||||
static int inno_hdmi_phy_remove(struct platform_device *pdev)
|
||||
static void inno_hdmi_phy_remove(struct platform_device *pdev)
|
||||
{
|
||||
of_clk_del_provider(pdev->dev.of_node);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static const struct of_device_id inno_hdmi_phy_of_match[] = {
|
||||
|
@ -1266,7 +1264,7 @@ MODULE_DEVICE_TABLE(of, inno_hdmi_phy_of_match);
|
|||
|
||||
static struct platform_driver inno_hdmi_phy_driver = {
|
||||
.probe = inno_hdmi_phy_probe,
|
||||
.remove = inno_hdmi_phy_remove,
|
||||
.remove_new = inno_hdmi_phy_remove,
|
||||
.driver = {
|
||||
.name = "inno-hdmi-phy",
|
||||
.of_match_table = inno_hdmi_phy_of_match,
|
||||
|
|
Загрузка…
Ссылка в новой задаче