exec: clarify reasoning for euid/egid reset
This section of code initially looks redundant, but is required. This improves the comment to explain more clearly why the reset is needed. Signed-off-by: Kees Cook <keescook@chromium.org> Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Родитель
7f427d3a60
Коммит
cb6fd68fdd
|
@ -1387,7 +1387,12 @@ static void bprm_fill_uid(struct linux_binprm *bprm)
|
|||
kuid_t uid;
|
||||
kgid_t gid;
|
||||
|
||||
/* clear any previous set[ug]id data from a previous binary */
|
||||
/*
|
||||
* Since this can be called multiple times (via prepare_binprm),
|
||||
* we must clear any previous work done when setting set[ug]id
|
||||
* bits from any earlier bprm->file uses (for example when run
|
||||
* first for a setuid script then again for its interpreter).
|
||||
*/
|
||||
bprm->cred->euid = current_euid();
|
||||
bprm->cred->egid = current_egid();
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче