rtc: rv3029: let the core handle rtc range
Despite the comment, the RV3029 uses a 7bit BCD register for the year, making 2079 the last supported year. Link: https://lore.kernel.org/r/20191214221022.622482-14-alexandre.belloni@bootlin.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
Родитель
9346f87066
Коммит
cbc943eb37
|
@ -405,14 +405,6 @@ static int rv3029_set_alarm(struct device *dev, struct rtc_wkalrm *alarm)
|
|||
int ret;
|
||||
u8 regs[8];
|
||||
|
||||
/*
|
||||
* The clock has an 8 bit wide bcd-coded register (they never learn)
|
||||
* for the year. tm_year is an offset from 1900 and we are interested
|
||||
* in the 2000-2099 range, so any value less than 100 is invalid.
|
||||
*/
|
||||
if (tm->tm_year < 100)
|
||||
return -EINVAL;
|
||||
|
||||
/* Activate all the alarms with AE_x bit */
|
||||
regs[RV3029_A_SC - RV3029_A_SC] = bin2bcd(tm->tm_sec) | RV3029_A_AE_X;
|
||||
regs[RV3029_A_MN - RV3029_A_SC] = bin2bcd(tm->tm_min) | RV3029_A_AE_X;
|
||||
|
@ -442,14 +434,6 @@ static int rv3029_set_time(struct device *dev, struct rtc_time *tm)
|
|||
u8 regs[8];
|
||||
int ret;
|
||||
|
||||
/*
|
||||
* The clock has an 8 bit wide bcd-coded register (they never learn)
|
||||
* for the year. tm_year is an offset from 1900 and we are interested
|
||||
* in the 2000-2099 range, so any value less than 100 is invalid.
|
||||
*/
|
||||
if (tm->tm_year < 100)
|
||||
return -EINVAL;
|
||||
|
||||
regs[RV3029_W_SEC - RV3029_W_SEC] = bin2bcd(tm->tm_sec);
|
||||
regs[RV3029_W_MINUTES - RV3029_W_SEC] = bin2bcd(tm->tm_min);
|
||||
regs[RV3029_W_HOURS - RV3029_W_SEC] = bin2bcd(tm->tm_hour);
|
||||
|
@ -751,6 +735,8 @@ static int rv3029_probe(struct device *dev, struct regmap *regmap, int irq,
|
|||
}
|
||||
|
||||
rv3029->rtc->ops = &rv3029_rtc_ops;
|
||||
rv3029->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000;
|
||||
rv3029->rtc->range_max = RTC_TIMESTAMP_END_2079;
|
||||
|
||||
return rtc_register_device(rv3029->rtc);
|
||||
}
|
||||
|
|
|
@ -167,6 +167,7 @@ struct rtc_device {
|
|||
#define RTC_TIMESTAMP_BEGIN_1900 -2208988800LL /* 1900-01-01 00:00:00 */
|
||||
#define RTC_TIMESTAMP_BEGIN_2000 946684800LL /* 2000-01-01 00:00:00 */
|
||||
#define RTC_TIMESTAMP_END_2063 2966371199LL /* 2063-12-31 23:59:59 */
|
||||
#define RTC_TIMESTAMP_END_2079 3471292799LL /* 2079-12-31 23:59:59 */
|
||||
#define RTC_TIMESTAMP_END_2099 4102444799LL /* 2099-12-31 23:59:59 */
|
||||
#define RTC_TIMESTAMP_END_2199 7258118399LL /* 2199-12-31 23:59:59 */
|
||||
#define RTC_TIMESTAMP_END_9999 253402300799LL /* 9999-12-31 23:59:59 */
|
||||
|
|
Загрузка…
Ссылка в новой задаче