From cc23e68fdf988162736ee0db9ed519ff8b630eba Mon Sep 17 00:00:00 2001 From: Martin Kaiser Date: Tue, 6 Apr 2021 22:48:23 +0200 Subject: [PATCH] staging: rtl8188eu: clean up usb_read8 Remove unnecessary variable, summarize declaration and assignment. Signed-off-by: Martin Kaiser Link: https://lore.kernel.org/r/20210406204829.18130-5-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c index 205a15dd67a5..0172405c815e 100644 --- a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c +++ b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c @@ -296,14 +296,10 @@ exit: u8 usb_read8(struct adapter *adapter, u32 addr) { - u16 wvalue; - u16 len; - u8 data = 0; + u16 wvalue = (u16)(addr & 0xffff); + u8 data; - wvalue = (u16)(addr & 0x0000ffff); - len = 1; - - usbctrl_vendorreq(adapter, wvalue, &data, len, REALTEK_USB_VENQT_READ); + usbctrl_vendorreq(adapter, wvalue, &data, 1, REALTEK_USB_VENQT_READ); return data; }