tcp: remove extra POLL_OUT added for finished active connect()
Commit45f119bf93
("tcp: remove header prediction") introduced a minor bug: the sk_state_change() and sk_wake_async() notifications for a completed active connection happen twice: once in this new spot inside tcp_finish_connect() and once in the existing code in tcp_rcv_synsent_state_process() immediately after it calls tcp_finish_connect(). This commit remoes the duplicate POLL_OUT notifications. Fixes:45f119bf93
("tcp: remove header prediction") Signed-off-by: Neal Cardwell <ncardwell@google.com> Cc: Florian Westphal <fw@strlen.de> Cc: Eric Dumazet <edumazet@google.com> Cc: Yuchung Cheng <ycheng@google.com> Acked-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Родитель
3a8f6f874f
Коммит
d06c3583c2
|
@ -5342,11 +5342,6 @@ void tcp_finish_connect(struct sock *sk, struct sk_buff *skb)
|
||||||
|
|
||||||
if (sock_flag(sk, SOCK_KEEPOPEN))
|
if (sock_flag(sk, SOCK_KEEPOPEN))
|
||||||
inet_csk_reset_keepalive_timer(sk, keepalive_time_when(tp));
|
inet_csk_reset_keepalive_timer(sk, keepalive_time_when(tp));
|
||||||
|
|
||||||
if (!sock_flag(sk, SOCK_DEAD)) {
|
|
||||||
sk->sk_state_change(sk);
|
|
||||||
sk_wake_async(sk, SOCK_WAKE_IO, POLL_OUT);
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
static bool tcp_rcv_fastopen_synack(struct sock *sk, struct sk_buff *synack,
|
static bool tcp_rcv_fastopen_synack(struct sock *sk, struct sk_buff *synack,
|
||||||
|
|
Загрузка…
Ссылка в новой задаче