f2fs: read page index before freeing
commit0ea295dd85
upstream. The function truncate_node frees the page with f2fs_put_page. However, the page index is read after that. So, the patch reads the index before freeing the page. Fixes:bf39c00a9a
("f2fs: drop obsolete node page when it is truncated") Cc: <stable@vger.kernel.org> Signed-off-by: Pan Bian <bianpan2016@163.com> Reviewed-by: Chao Yu <yuchao0@huawei.com> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
49c5a805a2
Коммит
d33655dbae
|
@ -694,6 +694,7 @@ static void truncate_node(struct dnode_of_data *dn)
|
||||||
{
|
{
|
||||||
struct f2fs_sb_info *sbi = F2FS_I_SB(dn->inode);
|
struct f2fs_sb_info *sbi = F2FS_I_SB(dn->inode);
|
||||||
struct node_info ni;
|
struct node_info ni;
|
||||||
|
pgoff_t index;
|
||||||
|
|
||||||
get_node_info(sbi, dn->nid, &ni);
|
get_node_info(sbi, dn->nid, &ni);
|
||||||
f2fs_bug_on(sbi, ni.blk_addr == NULL_ADDR);
|
f2fs_bug_on(sbi, ni.blk_addr == NULL_ADDR);
|
||||||
|
@ -712,10 +713,11 @@ static void truncate_node(struct dnode_of_data *dn)
|
||||||
clear_node_page_dirty(dn->node_page);
|
clear_node_page_dirty(dn->node_page);
|
||||||
set_sbi_flag(sbi, SBI_IS_DIRTY);
|
set_sbi_flag(sbi, SBI_IS_DIRTY);
|
||||||
|
|
||||||
|
index = dn->node_page->index;
|
||||||
f2fs_put_page(dn->node_page, 1);
|
f2fs_put_page(dn->node_page, 1);
|
||||||
|
|
||||||
invalidate_mapping_pages(NODE_MAPPING(sbi),
|
invalidate_mapping_pages(NODE_MAPPING(sbi),
|
||||||
dn->node_page->index, dn->node_page->index);
|
index, index);
|
||||||
|
|
||||||
dn->node_page = NULL;
|
dn->node_page = NULL;
|
||||||
trace_f2fs_truncate_node(dn->inode, dn->nid, ni.blk_addr);
|
trace_f2fs_truncate_node(dn->inode, dn->nid, ni.blk_addr);
|
||||||
|
|
Загрузка…
Ссылка в новой задаче