tty: Fix double grabbing of a spinlock

The HSO changes for kref introduced a recursive spinlock take. All
functions which call put_rxbuf_data already have serial->serial_lock
grabbed.

[Comment to code added-AC]

Signed-off-by: Denis Joseph Barrow <D.Barrow@option.com>
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Denis Joseph Barrow 2009-01-15 13:31:24 +00:00 коммит произвёл Linus Torvalds
Родитель fe41cbb164
Коммит d45eb81c3e
1 изменённых файлов: 1 добавлений и 2 удалений

Просмотреть файл

@ -2044,9 +2044,8 @@ static int put_rxbuf_data(struct urb *urb, struct hso_serial *serial)
return -2;
}
spin_lock(&serial->serial_lock);
/* All callers to put_rxbuf_data hold serial_lock */
tty = tty_kref_get(serial->tty);
spin_unlock(&serial->serial_lock);
/* Push data to tty */
if (tty) {