mfd: cros-ec: copy the whole event in get_next_event_xfer

Commit 57e94c8b97 caused cros-ec keyboard events
be truncated on many chromebooks so that Left and Right keys on Column 12 were
always 0. Use ret as memcpy len to fix this.

The old code was using ec_dev->event_size, which is the event payload/data size
excluding event_type header, for the length of the memcpy operation. Use ret
as memcpy length to avoid the off by one and copy the whole msg->data.

Fixes: 57e94c8b97 ("mfd: cros-ec: Increase maximum mkbp event size")

Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Tested-by: Emil Renner Berthing <kernel@esmil.dk>
Signed-off-by: Emil Karlson <jekarlson@gmail.com>
Signed-off-by: Benson Leung <bleung@chromium.org>
This commit is contained in:
Emil Karlson 2018-10-03 21:43:18 +03:00 коммит произвёл Benson Leung
Родитель 0238df646e
Коммит d4d2313a3c
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 1F09F57B0A2FE658
1 изменённых файлов: 1 добавлений и 1 удалений

Просмотреть файл

@ -520,7 +520,7 @@ static int get_next_event_xfer(struct cros_ec_device *ec_dev,
ret = cros_ec_cmd_xfer(ec_dev, msg); ret = cros_ec_cmd_xfer(ec_dev, msg);
if (ret > 0) { if (ret > 0) {
ec_dev->event_size = ret - 1; ec_dev->event_size = ret - 1;
memcpy(&ec_dev->event_data, msg->data, ec_dev->event_size); memcpy(&ec_dev->event_data, msg->data, ret);
} }
return ret; return ret;