misc: bcm-vk: fix set_q_num API precedence issue

Change set_q_num API to use if-else to make it more explicit,
and avoid a precedence rule issue.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Desmond Yan <desmond.yan@broadcom.com>
Signed-off-by: Scott Branden <scott.branden@broadcom.com>
Link: https://lore.kernel.org/r/20210129060403.14801-1-scott.branden@broadcom.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Desmond Yan 2021-01-28 22:04:03 -08:00 коммит произвёл Greg Kroah-Hartman
Родитель e4612ecd6f
Коммит d71277dc9b
1 изменённых файлов: 8 добавлений и 2 удалений

Просмотреть файл

@ -52,8 +52,14 @@ static u32 get_q_num(const struct vk_msg_blk *msg)
static void set_q_num(struct vk_msg_blk *msg, u32 q_num)
{
msg->trans_id = (msg->trans_id & ~BCM_VK_MSG_Q_MASK) |
(q_num >= VK_MSGQ_PER_CHAN_MAX) ? VK_MSGQ_NUM_DEFAULT : q_num;
u32 trans_q;
if (q_num >= VK_MSGQ_PER_CHAN_MAX)
trans_q = VK_MSGQ_NUM_DEFAULT;
else
trans_q = q_num;
msg->trans_id = (msg->trans_id & ~BCM_VK_MSG_Q_MASK) | trans_q;
}
static u32 get_msg_id(const struct vk_msg_blk *msg)