media: drxk_hard: check if parameter is not NULL
There is a smatch warning: drivers/media/dvb-frontends/drxk_hard.c: drivers/media/dvb-frontends/drxk_hard.c:1478 scu_command() error: we previously assumed 'parameter' could be null (see line 1467) Telling that parameter might be NULL. Well, it can't, due to the way the driver works, but it doesn't hurt to add a check, in order to shut up smatch. Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
Родитель
e7121ab405
Коммит
daad52c8aa
|
@ -1474,9 +1474,11 @@ static int scu_command(struct drxk_state *state,
|
|||
|
||||
/* assume that the command register is ready
|
||||
since it is checked afterwards */
|
||||
for (ii = parameter_len - 1; ii >= 0; ii -= 1) {
|
||||
buffer[cnt++] = (parameter[ii] & 0xFF);
|
||||
buffer[cnt++] = ((parameter[ii] >> 8) & 0xFF);
|
||||
if (parameter) {
|
||||
for (ii = parameter_len - 1; ii >= 0; ii -= 1) {
|
||||
buffer[cnt++] = (parameter[ii] & 0xFF);
|
||||
buffer[cnt++] = ((parameter[ii] >> 8) & 0xFF);
|
||||
}
|
||||
}
|
||||
buffer[cnt++] = (cmd & 0xFF);
|
||||
buffer[cnt++] = ((cmd >> 8) & 0xFF);
|
||||
|
|
Загрузка…
Ссылка в новой задаче