ASoC: dwc: dwc-i2s: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-63-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Uwe Kleine-König 2023-03-15 16:05:54 +01:00 коммит произвёл Mark Brown
Родитель 52675c1e9b
Коммит db3a56667e
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 24D68B725D5487D0
1 изменённых файлов: 2 добавлений и 3 удалений

Просмотреть файл

@ -730,7 +730,7 @@ err_clk_disable:
return ret; return ret;
} }
static int dw_i2s_remove(struct platform_device *pdev) static void dw_i2s_remove(struct platform_device *pdev)
{ {
struct dw_i2s_dev *dev = dev_get_drvdata(&pdev->dev); struct dw_i2s_dev *dev = dev_get_drvdata(&pdev->dev);
@ -738,7 +738,6 @@ static int dw_i2s_remove(struct platform_device *pdev)
clk_disable_unprepare(dev->clk); clk_disable_unprepare(dev->clk);
pm_runtime_disable(&pdev->dev); pm_runtime_disable(&pdev->dev);
return 0;
} }
#ifdef CONFIG_OF #ifdef CONFIG_OF
@ -756,7 +755,7 @@ static const struct dev_pm_ops dwc_pm_ops = {
static struct platform_driver dw_i2s_driver = { static struct platform_driver dw_i2s_driver = {
.probe = dw_i2s_probe, .probe = dw_i2s_probe,
.remove = dw_i2s_remove, .remove_new = dw_i2s_remove,
.driver = { .driver = {
.name = "designware-i2s", .name = "designware-i2s",
.of_match_table = of_match_ptr(dw_i2s_of_match), .of_match_table = of_match_ptr(dw_i2s_of_match),