media: bdisp: Fix runtime PM imbalance on error
pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Reviewed-by: Fabien Dessenne <fabien.dessenne@st.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Родитель
e883494376
Коммит
dbd2f2dc02
|
@ -1367,7 +1367,7 @@ static int bdisp_probe(struct platform_device *pdev)
|
||||||
ret = pm_runtime_get_sync(dev);
|
ret = pm_runtime_get_sync(dev);
|
||||||
if (ret < 0) {
|
if (ret < 0) {
|
||||||
dev_err(dev, "failed to set PM\n");
|
dev_err(dev, "failed to set PM\n");
|
||||||
goto err_dbg;
|
goto err_pm;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Filters */
|
/* Filters */
|
||||||
|
@ -1395,7 +1395,6 @@ err_filter:
|
||||||
bdisp_hw_free_filters(bdisp->dev);
|
bdisp_hw_free_filters(bdisp->dev);
|
||||||
err_pm:
|
err_pm:
|
||||||
pm_runtime_put(dev);
|
pm_runtime_put(dev);
|
||||||
err_dbg:
|
|
||||||
bdisp_debugfs_remove(bdisp);
|
bdisp_debugfs_remove(bdisp);
|
||||||
v4l2_device_unregister(&bdisp->v4l2_dev);
|
v4l2_device_unregister(&bdisp->v4l2_dev);
|
||||||
err_clk:
|
err_clk:
|
||||||
|
|
Загрузка…
Ссылка в новой задаче