mfd: Don't leak init_data in tps65910_i2c_probe
There are a couple of situations where we leak init_data in drivers/mfd/tps65910.c:tps65910_i2c_probe() - this patch should take care of them. Signed-off-by: Jesper Juhl <jj@chaosbits.net> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
This commit is contained in:
Родитель
f7eb6c5e8e
Коммит
dc7e412d43
|
@ -151,8 +151,10 @@ static int tps65910_i2c_probe(struct i2c_client *i2c,
|
|||
init_data->irq_base = pmic_plat_data->irq;
|
||||
|
||||
tps65910 = kzalloc(sizeof(struct tps65910), GFP_KERNEL);
|
||||
if (tps65910 == NULL)
|
||||
if (tps65910 == NULL) {
|
||||
kfree(init_data);
|
||||
return -ENOMEM;
|
||||
}
|
||||
|
||||
i2c_set_clientdata(i2c, tps65910);
|
||||
tps65910->dev = &i2c->dev;
|
||||
|
@ -174,11 +176,13 @@ static int tps65910_i2c_probe(struct i2c_client *i2c,
|
|||
if (ret < 0)
|
||||
goto err;
|
||||
|
||||
kfree(init_data);
|
||||
return ret;
|
||||
|
||||
err:
|
||||
mfd_remove_devices(tps65910->dev);
|
||||
kfree(tps65910);
|
||||
kfree(init_data);
|
||||
return ret;
|
||||
}
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче