tools lib traceevent: Handle NULL comm name
It is possible that a pid has no associated comm attached to it, although it can still be passed to pevent_register_comm(). But if comm is NULL, it will cause strdup() to segfault. To prevent this from happening, if comm is NULL use the default "<...>" name for the pid. Signed-off-by: Josef Bacik <jbacik@fb.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Namhyung Kim <namhyung@kernel.org> Link: http://lkml.kernel.org/r/20150324135922.549965495@goodmis.org Link: http://lkml.kernel.org/p/1403799732-30308-1-git-send-email-jbacik@fb.com Signed-off-by: Steven Rostedt <rostedt@goodmis.org> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Родитель
18425f13a0
Коммит
deab6f55a2
|
@ -304,7 +304,10 @@ int pevent_register_comm(struct pevent *pevent, const char *comm, int pid)
|
|||
if (!item)
|
||||
return -1;
|
||||
|
||||
item->comm = strdup(comm);
|
||||
if (comm)
|
||||
item->comm = strdup(comm);
|
||||
else
|
||||
item->comm = strdup("<...>");
|
||||
if (!item->comm) {
|
||||
free(item);
|
||||
return -1;
|
||||
|
|
Загрузка…
Ссылка в новой задаче