can: ti_hecc: ti_hecc_probe(): add missed clk_disable_unprepare() in error path
The driver forgets to call clk_disable_unprepare() in error path after
a success calling for clk_prepare_enable().
Fix it by adding a clk_disable_unprepare() in error path.
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Link: https://lore.kernel.org/r/1594973079-27743-1-git-send-email-zhangchangzhong@huawei.com
Fixes: befa60113c
("can: ti_hecc: add missing prepare and unprepare of the clock")
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
This commit is contained in:
Родитель
c3ddac4b0c
Коммит
e002103b36
|
@ -933,7 +933,7 @@ static int ti_hecc_probe(struct platform_device *pdev)
|
||||||
err = clk_prepare_enable(priv->clk);
|
err = clk_prepare_enable(priv->clk);
|
||||||
if (err) {
|
if (err) {
|
||||||
dev_err(&pdev->dev, "clk_prepare_enable() failed\n");
|
dev_err(&pdev->dev, "clk_prepare_enable() failed\n");
|
||||||
goto probe_exit_clk;
|
goto probe_exit_release_clk;
|
||||||
}
|
}
|
||||||
|
|
||||||
priv->offload.mailbox_read = ti_hecc_mailbox_read;
|
priv->offload.mailbox_read = ti_hecc_mailbox_read;
|
||||||
|
@ -942,7 +942,7 @@ static int ti_hecc_probe(struct platform_device *pdev)
|
||||||
err = can_rx_offload_add_timestamp(ndev, &priv->offload);
|
err = can_rx_offload_add_timestamp(ndev, &priv->offload);
|
||||||
if (err) {
|
if (err) {
|
||||||
dev_err(&pdev->dev, "can_rx_offload_add_timestamp() failed\n");
|
dev_err(&pdev->dev, "can_rx_offload_add_timestamp() failed\n");
|
||||||
goto probe_exit_clk;
|
goto probe_exit_disable_clk;
|
||||||
}
|
}
|
||||||
|
|
||||||
err = register_candev(ndev);
|
err = register_candev(ndev);
|
||||||
|
@ -960,7 +960,9 @@ static int ti_hecc_probe(struct platform_device *pdev)
|
||||||
|
|
||||||
probe_exit_offload:
|
probe_exit_offload:
|
||||||
can_rx_offload_del(&priv->offload);
|
can_rx_offload_del(&priv->offload);
|
||||||
probe_exit_clk:
|
probe_exit_disable_clk:
|
||||||
|
clk_disable_unprepare(priv->clk);
|
||||||
|
probe_exit_release_clk:
|
||||||
clk_put(priv->clk);
|
clk_put(priv->clk);
|
||||||
probe_exit_candev:
|
probe_exit_candev:
|
||||||
free_candev(ndev);
|
free_candev(ndev);
|
||||||
|
|
Загрузка…
Ссылка в новой задаче