From e24cf6b3891ca9f3f2ed2387adeda95e8364bf3e Mon Sep 17 00:00:00 2001 From: Florian Fainelli Date: Fri, 21 Sep 2018 15:30:05 -0700 Subject: [PATCH] net: dsa: b53: Don't assign autonegotiation enabled PHYLINK takes care of filing the right information into state->an_enabled, get rid of the read from the SerDes's BMCR register. Fixes: 0e01491de646 ("net: dsa: b53: Add SerDes support") Signed-off-by: Florian Fainelli Signed-off-by: David S. Miller --- drivers/net/dsa/b53/b53_serdes.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/dsa/b53/b53_serdes.c b/drivers/net/dsa/b53/b53_serdes.c index b45c55e0b8b4..629bf14128a2 100644 --- a/drivers/net/dsa/b53/b53_serdes.c +++ b/drivers/net/dsa/b53/b53_serdes.c @@ -100,15 +100,13 @@ int b53_serdes_link_state(struct b53_device *dev, int port, struct phylink_link_state *state) { u8 lane = b53_serdes_map_lane(dev, port); - u16 dig, bmcr, bmsr; + u16 dig, bmsr; if (lane == B53_INVALID_LANE) return 1; dig = b53_serdes_read(dev, lane, B53_SERDES_DIGITAL_STATUS, SERDES_DIGITAL_BLK); - bmcr = b53_serdes_read(dev, lane, B53_SERDES_MII_REG(MII_BMCR), - SERDES_MII_BLK); bmsr = b53_serdes_read(dev, lane, B53_SERDES_MII_REG(MII_BMSR), SERDES_MII_BLK); @@ -129,7 +127,6 @@ int b53_serdes_link_state(struct b53_device *dev, int port, } state->duplex = dig & DUPLEX_STATUS ? DUPLEX_FULL : DUPLEX_HALF; - state->an_enabled = !!(bmcr & BMCR_ANENABLE); state->an_complete = !!(bmsr & BMSR_ANEGCOMPLETE); state->link = !!(dig & LINK_STATUS); if (dig & PAUSE_RESOLUTION_RX_SIDE)