driver core: Set deferred_probe_timeout to a longer default if CONFIG_MODULES is set
When using modules, its common for the modules not to be loaded until quite late by userland. With the current code, driver_deferred_probe_check_state() will stop returning EPROBE_DEFER after late_initcall, which can cause module dependency resolution to fail after that. So allow a longer window of 30 seconds (picked somewhat arbitrarily, but influenced by the similar regulator core timeout value) in the case where modules are enabled. Cc: linux-pm@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Thierry Reding <treding@nvidia.com> Cc: Mark Brown <broonie@kernel.org> Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Saravana Kannan <saravanak@google.com> Cc: Todd Kjos <tkjos@google.com> Cc: Len Brown <len.brown@intel.com> Cc: Pavel Machek <pavel@ucw.cz> Cc: Ulf Hansson <ulf.hansson@linaro.org> Cc: Kevin Hilman <khilman@kernel.org> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> Cc: Rob Herring <robh@kernel.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: John Stultz <john.stultz@linaro.org> Link: https://lore.kernel.org/r/20200225050828.56458-3-john.stultz@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
c8c43cee29
Коммит
e2cec7d685
|
@ -224,7 +224,16 @@ static int deferred_devs_show(struct seq_file *s, void *data)
|
||||||
}
|
}
|
||||||
DEFINE_SHOW_ATTRIBUTE(deferred_devs);
|
DEFINE_SHOW_ATTRIBUTE(deferred_devs);
|
||||||
|
|
||||||
|
#ifdef CONFIG_MODULES
|
||||||
|
/*
|
||||||
|
* In the case of modules, set the default probe timeout to
|
||||||
|
* 30 seconds to give userland some time to load needed modules
|
||||||
|
*/
|
||||||
|
static int deferred_probe_timeout = 30;
|
||||||
|
#else
|
||||||
|
/* In the case of !modules, no probe timeout needed */
|
||||||
static int deferred_probe_timeout = -1;
|
static int deferred_probe_timeout = -1;
|
||||||
|
#endif
|
||||||
static int __init deferred_probe_timeout_setup(char *str)
|
static int __init deferred_probe_timeout_setup(char *str)
|
||||||
{
|
{
|
||||||
int timeout;
|
int timeout;
|
||||||
|
|
Загрузка…
Ссылка в новой задаче