bfin_can: rewrite the blackfin style of read/write to common ones
Replace the blackfin arch dependent style of bfin_read/bfin_write with common readw/writew Signed-off-by: Aaron Wu <Aaron.wu@analog.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
This commit is contained in:
Родитель
2f56f6be47
Коммит
e4936e01d0
|
@ -78,8 +78,8 @@ static int bfin_can_set_bittiming(struct net_device *dev)
|
||||||
if (priv->can.ctrlmode & CAN_CTRLMODE_3_SAMPLES)
|
if (priv->can.ctrlmode & CAN_CTRLMODE_3_SAMPLES)
|
||||||
timing |= SAM;
|
timing |= SAM;
|
||||||
|
|
||||||
bfin_write(®->clock, clk);
|
writew(clk, ®->clock);
|
||||||
bfin_write(®->timing, timing);
|
writew(timing, ®->timing);
|
||||||
|
|
||||||
netdev_info(dev, "setting CLOCK=0x%04x TIMING=0x%04x\n", clk, timing);
|
netdev_info(dev, "setting CLOCK=0x%04x TIMING=0x%04x\n", clk, timing);
|
||||||
|
|
||||||
|
@ -94,16 +94,14 @@ static void bfin_can_set_reset_mode(struct net_device *dev)
|
||||||
int i;
|
int i;
|
||||||
|
|
||||||
/* disable interrupts */
|
/* disable interrupts */
|
||||||
bfin_write(®->mbim1, 0);
|
writew(0, ®->mbim1);
|
||||||
bfin_write(®->mbim2, 0);
|
writew(0, ®->mbim2);
|
||||||
bfin_write(®->gim, 0);
|
writew(0, ®->gim);
|
||||||
|
|
||||||
/* reset can and enter configuration mode */
|
/* reset can and enter configuration mode */
|
||||||
bfin_write(®->control, SRS | CCR);
|
writew(SRS | CCR, ®->control);
|
||||||
SSYNC();
|
writew(CCR, ®->control);
|
||||||
bfin_write(®->control, CCR);
|
while (!(readw(®->control) & CCA)) {
|
||||||
SSYNC();
|
|
||||||
while (!(bfin_read(®->control) & CCA)) {
|
|
||||||
udelay(10);
|
udelay(10);
|
||||||
if (--timeout == 0) {
|
if (--timeout == 0) {
|
||||||
netdev_err(dev, "fail to enter configuration mode\n");
|
netdev_err(dev, "fail to enter configuration mode\n");
|
||||||
|
@ -116,34 +114,33 @@ static void bfin_can_set_reset_mode(struct net_device *dev)
|
||||||
* by writing to CAN Mailbox Configuration Registers 1 and 2
|
* by writing to CAN Mailbox Configuration Registers 1 and 2
|
||||||
* For all bits: 0 - Mailbox disabled, 1 - Mailbox enabled
|
* For all bits: 0 - Mailbox disabled, 1 - Mailbox enabled
|
||||||
*/
|
*/
|
||||||
bfin_write(®->mc1, 0);
|
writew(0, ®->mc1);
|
||||||
bfin_write(®->mc2, 0);
|
writew(0, ®->mc2);
|
||||||
|
|
||||||
/* Set Mailbox Direction */
|
/* Set Mailbox Direction */
|
||||||
bfin_write(®->md1, 0xFFFF); /* mailbox 1-16 are RX */
|
writew(0xFFFF, ®->md1); /* mailbox 1-16 are RX */
|
||||||
bfin_write(®->md2, 0); /* mailbox 17-32 are TX */
|
writew(0, ®->md2); /* mailbox 17-32 are TX */
|
||||||
|
|
||||||
/* RECEIVE_STD_CHL */
|
/* RECEIVE_STD_CHL */
|
||||||
for (i = 0; i < 2; i++) {
|
for (i = 0; i < 2; i++) {
|
||||||
bfin_write(®->chl[RECEIVE_STD_CHL + i].id0, 0);
|
writew(0, ®->chl[RECEIVE_STD_CHL + i].id0);
|
||||||
bfin_write(®->chl[RECEIVE_STD_CHL + i].id1, AME);
|
writew(AME, ®->chl[RECEIVE_STD_CHL + i].id1);
|
||||||
bfin_write(®->chl[RECEIVE_STD_CHL + i].dlc, 0);
|
writew(0, ®->chl[RECEIVE_STD_CHL + i].dlc);
|
||||||
bfin_write(®->msk[RECEIVE_STD_CHL + i].amh, 0x1FFF);
|
writew(0x1FFF, ®->msk[RECEIVE_STD_CHL + i].amh);
|
||||||
bfin_write(®->msk[RECEIVE_STD_CHL + i].aml, 0xFFFF);
|
writew(0xFFFF, ®->msk[RECEIVE_STD_CHL + i].aml);
|
||||||
}
|
}
|
||||||
|
|
||||||
/* RECEIVE_EXT_CHL */
|
/* RECEIVE_EXT_CHL */
|
||||||
for (i = 0; i < 2; i++) {
|
for (i = 0; i < 2; i++) {
|
||||||
bfin_write(®->chl[RECEIVE_EXT_CHL + i].id0, 0);
|
writew(0, ®->chl[RECEIVE_EXT_CHL + i].id0);
|
||||||
bfin_write(®->chl[RECEIVE_EXT_CHL + i].id1, AME | IDE);
|
writew(AME | IDE, ®->chl[RECEIVE_EXT_CHL + i].id1);
|
||||||
bfin_write(®->chl[RECEIVE_EXT_CHL + i].dlc, 0);
|
writew(0, ®->chl[RECEIVE_EXT_CHL + i].dlc);
|
||||||
bfin_write(®->msk[RECEIVE_EXT_CHL + i].amh, 0x1FFF);
|
writew(0x1FFF, ®->msk[RECEIVE_EXT_CHL + i].amh);
|
||||||
bfin_write(®->msk[RECEIVE_EXT_CHL + i].aml, 0xFFFF);
|
writew(0xFFFF, ®->msk[RECEIVE_EXT_CHL + i].aml);
|
||||||
}
|
}
|
||||||
|
|
||||||
bfin_write(®->mc2, BIT(TRANSMIT_CHL - 16));
|
writew(BIT(TRANSMIT_CHL - 16), ®->mc2);
|
||||||
bfin_write(®->mc1, BIT(RECEIVE_STD_CHL) + BIT(RECEIVE_EXT_CHL));
|
writew(BIT(RECEIVE_STD_CHL) + BIT(RECEIVE_EXT_CHL), ®->mc1);
|
||||||
SSYNC();
|
|
||||||
|
|
||||||
priv->can.state = CAN_STATE_STOPPED;
|
priv->can.state = CAN_STATE_STOPPED;
|
||||||
}
|
}
|
||||||
|
@ -157,9 +154,9 @@ static void bfin_can_set_normal_mode(struct net_device *dev)
|
||||||
/*
|
/*
|
||||||
* leave configuration mode
|
* leave configuration mode
|
||||||
*/
|
*/
|
||||||
bfin_write(®->control, bfin_read(®->control) & ~CCR);
|
writew(readw(®->control) & ~CCR, ®->control);
|
||||||
|
|
||||||
while (bfin_read(®->status) & CCA) {
|
while (readw(®->status) & CCA) {
|
||||||
udelay(10);
|
udelay(10);
|
||||||
if (--timeout == 0) {
|
if (--timeout == 0) {
|
||||||
netdev_err(dev, "fail to leave configuration mode\n");
|
netdev_err(dev, "fail to leave configuration mode\n");
|
||||||
|
@ -170,26 +167,25 @@ static void bfin_can_set_normal_mode(struct net_device *dev)
|
||||||
/*
|
/*
|
||||||
* clear _All_ tx and rx interrupts
|
* clear _All_ tx and rx interrupts
|
||||||
*/
|
*/
|
||||||
bfin_write(®->mbtif1, 0xFFFF);
|
writew(0xFFFF, ®->mbtif1);
|
||||||
bfin_write(®->mbtif2, 0xFFFF);
|
writew(0xFFFF, ®->mbtif2);
|
||||||
bfin_write(®->mbrif1, 0xFFFF);
|
writew(0xFFFF, ®->mbrif1);
|
||||||
bfin_write(®->mbrif2, 0xFFFF);
|
writew(0xFFFF, ®->mbrif2);
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* clear global interrupt status register
|
* clear global interrupt status register
|
||||||
*/
|
*/
|
||||||
bfin_write(®->gis, 0x7FF); /* overwrites with '1' */
|
writew(0x7FF, ®->gis); /* overwrites with '1' */
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* Initialize Interrupts
|
* Initialize Interrupts
|
||||||
* - set bits in the mailbox interrupt mask register
|
* - set bits in the mailbox interrupt mask register
|
||||||
* - global interrupt mask
|
* - global interrupt mask
|
||||||
*/
|
*/
|
||||||
bfin_write(®->mbim1, BIT(RECEIVE_STD_CHL) + BIT(RECEIVE_EXT_CHL));
|
writew(BIT(RECEIVE_STD_CHL) + BIT(RECEIVE_EXT_CHL), ®->mbim1);
|
||||||
bfin_write(®->mbim2, BIT(TRANSMIT_CHL - 16));
|
writew(BIT(TRANSMIT_CHL - 16), ®->mbim2);
|
||||||
|
|
||||||
bfin_write(®->gim, EPIM | BOIM | RMLIM);
|
writew(EPIM | BOIM | RMLIM, ®->gim);
|
||||||
SSYNC();
|
|
||||||
}
|
}
|
||||||
|
|
||||||
static void bfin_can_start(struct net_device *dev)
|
static void bfin_can_start(struct net_device *dev)
|
||||||
|
@ -226,7 +222,7 @@ static int bfin_can_get_berr_counter(const struct net_device *dev,
|
||||||
struct bfin_can_priv *priv = netdev_priv(dev);
|
struct bfin_can_priv *priv = netdev_priv(dev);
|
||||||
struct bfin_can_regs __iomem *reg = priv->membase;
|
struct bfin_can_regs __iomem *reg = priv->membase;
|
||||||
|
|
||||||
u16 cec = bfin_read(®->cec);
|
u16 cec = readw(®->cec);
|
||||||
|
|
||||||
bec->txerr = cec >> 8;
|
bec->txerr = cec >> 8;
|
||||||
bec->rxerr = cec;
|
bec->rxerr = cec;
|
||||||
|
@ -252,28 +248,28 @@ static int bfin_can_start_xmit(struct sk_buff *skb, struct net_device *dev)
|
||||||
|
|
||||||
/* fill id */
|
/* fill id */
|
||||||
if (id & CAN_EFF_FLAG) {
|
if (id & CAN_EFF_FLAG) {
|
||||||
bfin_write(®->chl[TRANSMIT_CHL].id0, id);
|
writew(id, ®->chl[TRANSMIT_CHL].id0);
|
||||||
val = ((id & 0x1FFF0000) >> 16) | IDE;
|
val = ((id & 0x1FFF0000) >> 16) | IDE;
|
||||||
} else
|
} else
|
||||||
val = (id << 2);
|
val = (id << 2);
|
||||||
if (id & CAN_RTR_FLAG)
|
if (id & CAN_RTR_FLAG)
|
||||||
val |= RTR;
|
val |= RTR;
|
||||||
bfin_write(®->chl[TRANSMIT_CHL].id1, val | AME);
|
writew(val | AME, ®->chl[TRANSMIT_CHL].id1);
|
||||||
|
|
||||||
/* fill payload */
|
/* fill payload */
|
||||||
for (i = 0; i < 8; i += 2) {
|
for (i = 0; i < 8; i += 2) {
|
||||||
val = ((7 - i) < dlc ? (data[7 - i]) : 0) +
|
val = ((7 - i) < dlc ? (data[7 - i]) : 0) +
|
||||||
((6 - i) < dlc ? (data[6 - i] << 8) : 0);
|
((6 - i) < dlc ? (data[6 - i] << 8) : 0);
|
||||||
bfin_write(®->chl[TRANSMIT_CHL].data[i], val);
|
writew(val, ®->chl[TRANSMIT_CHL].data[i]);
|
||||||
}
|
}
|
||||||
|
|
||||||
/* fill data length code */
|
/* fill data length code */
|
||||||
bfin_write(®->chl[TRANSMIT_CHL].dlc, dlc);
|
writew(dlc, ®->chl[TRANSMIT_CHL].dlc);
|
||||||
|
|
||||||
can_put_echo_skb(skb, dev, 0);
|
can_put_echo_skb(skb, dev, 0);
|
||||||
|
|
||||||
/* set transmit request */
|
/* set transmit request */
|
||||||
bfin_write(®->trs2, BIT(TRANSMIT_CHL - 16));
|
writew(BIT(TRANSMIT_CHL - 16), ®->trs2);
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
@ -296,26 +292,26 @@ static void bfin_can_rx(struct net_device *dev, u16 isrc)
|
||||||
/* get id */
|
/* get id */
|
||||||
if (isrc & BIT(RECEIVE_EXT_CHL)) {
|
if (isrc & BIT(RECEIVE_EXT_CHL)) {
|
||||||
/* extended frame format (EFF) */
|
/* extended frame format (EFF) */
|
||||||
cf->can_id = ((bfin_read(®->chl[RECEIVE_EXT_CHL].id1)
|
cf->can_id = ((readw(®->chl[RECEIVE_EXT_CHL].id1)
|
||||||
& 0x1FFF) << 16)
|
& 0x1FFF) << 16)
|
||||||
+ bfin_read(®->chl[RECEIVE_EXT_CHL].id0);
|
+ readw(®->chl[RECEIVE_EXT_CHL].id0);
|
||||||
cf->can_id |= CAN_EFF_FLAG;
|
cf->can_id |= CAN_EFF_FLAG;
|
||||||
obj = RECEIVE_EXT_CHL;
|
obj = RECEIVE_EXT_CHL;
|
||||||
} else {
|
} else {
|
||||||
/* standard frame format (SFF) */
|
/* standard frame format (SFF) */
|
||||||
cf->can_id = (bfin_read(®->chl[RECEIVE_STD_CHL].id1)
|
cf->can_id = (readw(®->chl[RECEIVE_STD_CHL].id1)
|
||||||
& 0x1ffc) >> 2;
|
& 0x1ffc) >> 2;
|
||||||
obj = RECEIVE_STD_CHL;
|
obj = RECEIVE_STD_CHL;
|
||||||
}
|
}
|
||||||
if (bfin_read(®->chl[obj].id1) & RTR)
|
if (readw(®->chl[obj].id1) & RTR)
|
||||||
cf->can_id |= CAN_RTR_FLAG;
|
cf->can_id |= CAN_RTR_FLAG;
|
||||||
|
|
||||||
/* get data length code */
|
/* get data length code */
|
||||||
cf->can_dlc = get_can_dlc(bfin_read(®->chl[obj].dlc) & 0xF);
|
cf->can_dlc = get_can_dlc(readw(®->chl[obj].dlc) & 0xF);
|
||||||
|
|
||||||
/* get payload */
|
/* get payload */
|
||||||
for (i = 0; i < 8; i += 2) {
|
for (i = 0; i < 8; i += 2) {
|
||||||
val = bfin_read(®->chl[obj].data[i]);
|
val = readw(®->chl[obj].data[i]);
|
||||||
cf->data[7 - i] = (7 - i) < cf->can_dlc ? val : 0;
|
cf->data[7 - i] = (7 - i) < cf->can_dlc ? val : 0;
|
||||||
cf->data[6 - i] = (6 - i) < cf->can_dlc ? (val >> 8) : 0;
|
cf->data[6 - i] = (6 - i) < cf->can_dlc ? (val >> 8) : 0;
|
||||||
}
|
}
|
||||||
|
@ -369,7 +365,7 @@ static int bfin_can_err(struct net_device *dev, u16 isrc, u16 status)
|
||||||
|
|
||||||
if (state != priv->can.state && (state == CAN_STATE_ERROR_WARNING ||
|
if (state != priv->can.state && (state == CAN_STATE_ERROR_WARNING ||
|
||||||
state == CAN_STATE_ERROR_PASSIVE)) {
|
state == CAN_STATE_ERROR_PASSIVE)) {
|
||||||
u16 cec = bfin_read(®->cec);
|
u16 cec = readw(®->cec);
|
||||||
u8 rxerr = cec;
|
u8 rxerr = cec;
|
||||||
u8 txerr = cec >> 8;
|
u8 txerr = cec >> 8;
|
||||||
|
|
||||||
|
@ -420,23 +416,23 @@ static irqreturn_t bfin_can_interrupt(int irq, void *dev_id)
|
||||||
struct net_device_stats *stats = &dev->stats;
|
struct net_device_stats *stats = &dev->stats;
|
||||||
u16 status, isrc;
|
u16 status, isrc;
|
||||||
|
|
||||||
if ((irq == priv->tx_irq) && bfin_read(®->mbtif2)) {
|
if ((irq == priv->tx_irq) && readw(®->mbtif2)) {
|
||||||
/* transmission complete interrupt */
|
/* transmission complete interrupt */
|
||||||
bfin_write(®->mbtif2, 0xFFFF);
|
writew(0xFFFF, ®->mbtif2);
|
||||||
stats->tx_packets++;
|
stats->tx_packets++;
|
||||||
stats->tx_bytes += bfin_read(®->chl[TRANSMIT_CHL].dlc);
|
stats->tx_bytes += readw(®->chl[TRANSMIT_CHL].dlc);
|
||||||
can_get_echo_skb(dev, 0);
|
can_get_echo_skb(dev, 0);
|
||||||
netif_wake_queue(dev);
|
netif_wake_queue(dev);
|
||||||
} else if ((irq == priv->rx_irq) && bfin_read(®->mbrif1)) {
|
} else if ((irq == priv->rx_irq) && readw(®->mbrif1)) {
|
||||||
/* receive interrupt */
|
/* receive interrupt */
|
||||||
isrc = bfin_read(®->mbrif1);
|
isrc = readw(®->mbrif1);
|
||||||
bfin_write(®->mbrif1, 0xFFFF);
|
writew(0xFFFF, ®->mbrif1);
|
||||||
bfin_can_rx(dev, isrc);
|
bfin_can_rx(dev, isrc);
|
||||||
} else if ((irq == priv->err_irq) && bfin_read(®->gis)) {
|
} else if ((irq == priv->err_irq) && readw(®->gis)) {
|
||||||
/* error interrupt */
|
/* error interrupt */
|
||||||
isrc = bfin_read(®->gis);
|
isrc = readw(®->gis);
|
||||||
status = bfin_read(®->esr);
|
status = readw(®->esr);
|
||||||
bfin_write(®->gis, 0x7FF);
|
writew(0x7FF, ®->gis);
|
||||||
bfin_can_err(dev, isrc, status);
|
bfin_can_err(dev, isrc, status);
|
||||||
} else {
|
} else {
|
||||||
return IRQ_NONE;
|
return IRQ_NONE;
|
||||||
|
@ -641,9 +637,8 @@ static int bfin_can_suspend(struct platform_device *pdev, pm_message_t mesg)
|
||||||
|
|
||||||
if (netif_running(dev)) {
|
if (netif_running(dev)) {
|
||||||
/* enter sleep mode */
|
/* enter sleep mode */
|
||||||
bfin_write(®->control, bfin_read(®->control) | SMR);
|
writew(readw(®->control) | SMR, ®->control);
|
||||||
SSYNC();
|
while (!(readw(®->intr) & SMACK)) {
|
||||||
while (!(bfin_read(®->intr) & SMACK)) {
|
|
||||||
udelay(10);
|
udelay(10);
|
||||||
if (--timeout == 0) {
|
if (--timeout == 0) {
|
||||||
netdev_err(dev, "fail to enter sleep mode\n");
|
netdev_err(dev, "fail to enter sleep mode\n");
|
||||||
|
@ -663,8 +658,7 @@ static int bfin_can_resume(struct platform_device *pdev)
|
||||||
|
|
||||||
if (netif_running(dev)) {
|
if (netif_running(dev)) {
|
||||||
/* leave sleep mode */
|
/* leave sleep mode */
|
||||||
bfin_write(®->intr, 0);
|
writew(0, ®->intr);
|
||||||
SSYNC();
|
|
||||||
}
|
}
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
|
|
Загрузка…
Ссылка в новой задаче