perf hists: Update the column width for the "srcline" sort key
When we introduce a new sort key, we need to update the
hists__calc_col_len() function accordingly, otherwise the width
will be limited to strlen(header).
We can't update it when obtaining a line value for a column (for
instance, in sort__srcline_cmp()), because we reset it all when doing a
resort (see hists__output_recalc_col_len()), so we need to, from what is
in the hist_entry fields, set each of the column widths.
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Fixes: 409a8be615
("perf tools: Add sort by src line/number")
Link: http://lkml.kernel.org/n/tip-jgbe0yx8v1gs89cslr93pvz2@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Родитель
5cef897652
Коммит
e8e6d37e73
|
@ -151,6 +151,9 @@ void hists__calc_col_len(struct hists *hists, struct hist_entry *h)
|
||||||
hists__new_col_len(hists, HISTC_LOCAL_WEIGHT, 12);
|
hists__new_col_len(hists, HISTC_LOCAL_WEIGHT, 12);
|
||||||
hists__new_col_len(hists, HISTC_GLOBAL_WEIGHT, 12);
|
hists__new_col_len(hists, HISTC_GLOBAL_WEIGHT, 12);
|
||||||
|
|
||||||
|
if (h->srcline)
|
||||||
|
hists__new_col_len(hists, HISTC_SRCLINE, strlen(h->srcline));
|
||||||
|
|
||||||
if (h->transaction)
|
if (h->transaction)
|
||||||
hists__new_col_len(hists, HISTC_TRANSACTION,
|
hists__new_col_len(hists, HISTC_TRANSACTION,
|
||||||
hist_entry__transaction_len());
|
hist_entry__transaction_len());
|
||||||
|
|
Загрузка…
Ссылка в новой задаче