media: atomisp: remove an impossible condition
Changesetdc9f65cf9a
("media: staging: atomisp: avoid a warning if 32 bits build") was meant to solve an impossible condition when building with 32 bits. It turns that this impossible condition also happens wit 64 bits: drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c:698 gmin_get_config_var() warn: impossible condition '(*out_len > (~0)) => (0-u64max > u64max)' After a further analysis, this condition will always be false as, on all architectures, size_t doesn't have more bits than unsigned long. Also, the only two archs that really matter are x86 and x86_64, as this driver doesn't build on other archs (as it depends on X86-specific UEFI support). So, just drop the useless code. Fixes:dc9f65cf9a
("media: staging: atomisp: avoid a warning if 32 bits build") Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Родитель
b66d448487
Коммит
e935dbfc9f
|
@ -693,12 +693,6 @@ static int gmin_get_config_var(struct device *dev, const char *var,
|
|||
for (i = 0; i < sizeof(var8) && var8[i]; i++)
|
||||
var16[i] = var8[i];
|
||||
|
||||
#ifdef CONFIG_64BIT
|
||||
/* To avoid owerflows when calling the efivar API */
|
||||
if (*out_len > ULONG_MAX)
|
||||
return -EINVAL;
|
||||
#endif
|
||||
|
||||
/* Not sure this API usage is kosher; efivar_entry_get()'s
|
||||
* implementation simply uses VariableName and VendorGuid from
|
||||
* the struct and ignores the rest, but it seems like there
|
||||
|
|
Загрузка…
Ссылка в новой задаче