workqueue: Provide destroy_delayed_work_on_stack()

If a delayed or deferrable work is on stack we need to tell debug
objects that we are destroying the timer and the work. Otherwise we
leak the tracking object.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Acked-by: Tejun Heo <tj@kernel.org>
Link: http://lkml.kernel.org/r/20140323141939.911487677@linutronix.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
This commit is contained in:
Thomas Gleixner 2014-03-23 14:20:44 +00:00
Родитель 87291a9267
Коммит ea2e64f280
2 изменённых файлов: 9 добавлений и 0 удалений

Просмотреть файл

@ -191,6 +191,7 @@ struct execute_work {
#ifdef CONFIG_DEBUG_OBJECTS_WORK #ifdef CONFIG_DEBUG_OBJECTS_WORK
extern void __init_work(struct work_struct *work, int onstack); extern void __init_work(struct work_struct *work, int onstack);
extern void destroy_work_on_stack(struct work_struct *work); extern void destroy_work_on_stack(struct work_struct *work);
extern void destroy_delayed_work_on_stack(struct delayed_work *work);
static inline unsigned int work_static(struct work_struct *work) static inline unsigned int work_static(struct work_struct *work)
{ {
return *work_data_bits(work) & WORK_STRUCT_STATIC; return *work_data_bits(work) & WORK_STRUCT_STATIC;
@ -198,6 +199,7 @@ static inline unsigned int work_static(struct work_struct *work)
#else #else
static inline void __init_work(struct work_struct *work, int onstack) { } static inline void __init_work(struct work_struct *work, int onstack) { }
static inline void destroy_work_on_stack(struct work_struct *work) { } static inline void destroy_work_on_stack(struct work_struct *work) { }
static inline void destroy_delayed_work_on_stack(struct delayed_work *work) { }
static inline unsigned int work_static(struct work_struct *work) { return 0; } static inline unsigned int work_static(struct work_struct *work) { return 0; }
#endif #endif

Просмотреть файл

@ -516,6 +516,13 @@ void destroy_work_on_stack(struct work_struct *work)
} }
EXPORT_SYMBOL_GPL(destroy_work_on_stack); EXPORT_SYMBOL_GPL(destroy_work_on_stack);
void destroy_delayed_work_on_stack(struct delayed_work *work)
{
destroy_timer_on_stack(&work->timer);
debug_object_free(&work->work, &work_debug_descr);
}
EXPORT_SYMBOL_GPL(destroy_delayed_work_on_stack);
#else #else
static inline void debug_work_activate(struct work_struct *work) { } static inline void debug_work_activate(struct work_struct *work) { }
static inline void debug_work_deactivate(struct work_struct *work) { } static inline void debug_work_deactivate(struct work_struct *work) { }