ASoC: apple: mca: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Takashi Iwai <tiwai@suse.de> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> Link: https://lore.kernel.org/r/20230315150745.67084-24-u.kleine-koenig@pengutronix.de Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Родитель
0e940c75e3
Коммит
eb5a9cf29f
|
@ -1159,13 +1159,12 @@ err_release:
|
|||
return ret;
|
||||
}
|
||||
|
||||
static int apple_mca_remove(struct platform_device *pdev)
|
||||
static void apple_mca_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct mca_data *mca = platform_get_drvdata(pdev);
|
||||
|
||||
snd_soc_unregister_component(&pdev->dev);
|
||||
apple_mca_release(mca);
|
||||
return 0;
|
||||
}
|
||||
|
||||
static const struct of_device_id apple_mca_of_match[] = {
|
||||
|
@ -1180,7 +1179,7 @@ static struct platform_driver apple_mca_driver = {
|
|||
.of_match_table = apple_mca_of_match,
|
||||
},
|
||||
.probe = apple_mca_probe,
|
||||
.remove = apple_mca_remove,
|
||||
.remove_new = apple_mca_remove,
|
||||
};
|
||||
module_platform_driver(apple_mca_driver);
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче