devcgroup: fix permission check when adding entry to child cgroup
# cat devices.list c 1:3 r # echo 'c 1:3 w' > sub/devices.allow # cat sub/devices.list c 1:3 w As illustrated, the parent group has no write permission to /dev/null, so it's child should not be allowed to add this write permission. Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> Acked-by: Serge Hallyn <serue@us.ibm.com> Cc: Serge Hallyn <serue@us.ibm.com> Cc: Paul Menage <menage@google.com> Cc: Pavel Emelyanov <xemul@openvz.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Родитель
17d213f806
Коммит
ec229e8300
|
@ -300,7 +300,7 @@ static int may_access_whitelist(struct dev_cgroup *c,
|
|||
continue;
|
||||
if (whitem->minor != ~0 && whitem->minor != refwh->minor)
|
||||
continue;
|
||||
if (refwh->access & (~(whitem->access | ACC_MASK)))
|
||||
if (refwh->access & (~whitem->access))
|
||||
continue;
|
||||
return 1;
|
||||
}
|
||||
|
|
Загрузка…
Ссылка в новой задаче