dm mpath: cleanup reinstate_path() et al based on code review
fail_path() will print a "Failing path ..." message but reinstate_path() doesn't print a "Reinstating path ...". Add that message to reinstate_path() to add symmetry and aid system debugging. Remove reinstate_path()'s check for the path_selector providing .reinstate_path hook. All path selectors provide this and any future ones must too. activate_path() calls pg_init_done() with SCSI_DH_DEV_OFFLINED but pg_init_done() doesn't expicitly handle it in its swicth statement. Add SCSI_DH_DEV_OFFLINED to the default case. Signed-off-by: Mike Snitzer <snitzer@redhat.com>
This commit is contained in:
Родитель
9f54cec553
Коммит
ec31f3f78a
|
@ -1017,12 +1017,7 @@ static int reinstate_path(struct pgpath *pgpath)
|
|||
if (pgpath->is_active)
|
||||
goto out;
|
||||
|
||||
if (!pgpath->pg->ps.type->reinstate_path) {
|
||||
DMWARN("Reinstate path not supported by path selector %s",
|
||||
pgpath->pg->ps.type->name);
|
||||
r = -EINVAL;
|
||||
goto out;
|
||||
}
|
||||
DMWARN("Reinstating path %s.", pgpath->path.dev->name);
|
||||
|
||||
r = pgpath->pg->ps.type->reinstate_path(&pgpath->pg->ps, &pgpath->path);
|
||||
if (r)
|
||||
|
@ -1207,6 +1202,7 @@ static void pg_init_done(void *data, int errors)
|
|||
fail_path(pgpath);
|
||||
errors = 0;
|
||||
break;
|
||||
case SCSI_DH_DEV_OFFLINED:
|
||||
default:
|
||||
/*
|
||||
* We probably do not want to fail the path for a device
|
||||
|
|
Загрузка…
Ссылка в новой задаче